Fix TestIMDS flaky test #4797
Merged
Fix TestIMDS flaky test #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ami filter we were using picked up a new AMI which had a minimum volume size of 30. This PR modifies the filter to be a little more specific to filter out these special case AMIs. e.g. - `amazon/al2023-ami-2023.6.20241111.0-kernel-6.1-x86_64` (good) - `amazon/al2023-ami-ecs-neuron-hvm-2023.0.20241115-kernel-6.1-x86_64` (bad)
flostadler
approved these changes
Nov 18, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
t0yv0
approved these changes
Nov 18, 2024
|
This PR has been shipped in release v6.60.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ami filter we were using picked up a new AMI which had a minimum
volume size of 30. This PR modifies the filter to be a little more
specific to filter out these special case AMIs.
e.g.
amazon/al2023-ami-2023.6.20241111.0-kernel-6.1-x86_64(good)amazon/al2023-ami-ecs-neuron-hvm-2023.0.20241115-kernel-6.1-x86_64(bad)