Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v1.41.0 of AWS Terraform Provider #355

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Update to v1.41.0 of AWS Terraform Provider #355

merged 1 commit into from
Oct 22, 2018

Conversation

lukehoban
Copy link
Contributor

No description provided.

@lukehoban lukehoban requested review from jen20 and pgavlin October 20, 2018 21:55
jen20
jen20 approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@jen20 jen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. A local build shows no unmapped resources - I'll investigate the other warnings but I they are all docs-related rather than caused by this.

jen20
jen20 approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@jen20 jen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - a local build doesn't show any new unmapped resources. I'll investigate the documentation warnings but that can be done separately to this PR.

jen20
jen20 approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@jen20 jen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - a local build doesn't show any new unmapped resources. I'll investigate the documentation warnings but that can be done separately to this PR.

jen20
jen20 approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@jen20 jen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. A local build shows no unmapped resources - I'll investigate the other warnings but I they are all docs-related rather than caused by this.

jen20
jen20 approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@jen20 jen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a local build doesn't show any new unmapped resources.

@lukehoban lukehoban merged commit 276c743 into master Oct 22, 2018
@pulumi-bot pulumi-bot deleted the lukehoban/tfawsv1410 branch October 22, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen20 jen20 jen20 approved these changes

@pgavlin pgavlin Awaiting requested review from pgavlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukehoban @jen20