Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terraform-provider-aws to v1.38.0. #341

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Update terraform-provider-aws to v1.38.0. #341

merged 3 commits into from
Sep 28, 2018

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Sep 27, 2018

No description provided.

@pgavlin pgavlin requested review from lukehoban and jen20 September 27, 2018 17:55
@lukehoban
Copy link
Contributor

I don't see any updates to resources.go - but I do see a new data source at https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md#1380-september-26-2018. Are there new warnings in the build now about these new data sources being unmapped?

In general, we should add support for all newly exposed APIs as part of updating the TF provider.

lukehoban
lukehoban reviewed Sep 27, 2018
View reviewed changes
sdk/nodejs/applicationloadbalancing/listener.ts
@@ -33,17 +33,17 @@ export class Listener extends pulumi.CustomResource {
/**
* An Action block. Action blocks are documented below.
*/
public readonly defaultActions: pulumi.Output<{ targetGroupArn: string, type: string }[]>;
public readonly defaultAction: pulumi.Output<{ fixedResponse?: { contentType: string, messageBody?: string, statusCode: string }, redirect?: { host?: string, path?: string, port?: string, protocol?: string, query?: string, statusCode: string }, targetGroupArn?: string, type: string }>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. This will be a breaking change. Looks like a case there MaxItems==1 was added in TF, which is not really breaking, but that causes us to project this differently.

I don't think there is anything we can/should do here - but worth marking this as breaking and adding a note to the PR.

@pgavlin
Copy link
Member Author

pgavlin commented Sep 27, 2018

Are there new warnings in the build now about these new data sources being unmapped?

I did not look, to be honest. I will check.

@pgavlin
Copy link
Member Author

pgavlin commented Sep 27, 2018

@lukehoban I've added the missing resources and data sources.

lukehoban
lukehoban approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgavlin pgavlin added the impact/breaking Fixing this issue will require a breaking change label Sep 28, 2018
@pgavlin pgavlin merged commit 2159b44 into master Sep 28, 2018
@pulumi-bot pulumi-bot deleted the pgavlin/updateProvider branch September 28, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban approved these changes

@jen20 jen20 Awaiting requested review from jen20

Assignees
No one assigned
Labels
impact/breaking Fixing this issue will require a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgavlin @lukehoban