Expose 'factory functions' from pulumi-aws #304
Conversation
…serverless function.
| @@ -16,13 +16,13 @@ function createServer(region: aws.Region): aws.ec2.Instance { | |||
| ingress: [ | |||
| { protocol: "tcp", fromPort: 80, toPort: 80, cidrBlocks: ["0.0.0.0/0"] }, | |||
| ], | |||
| }, { provider: provider }); | |||
|
|
|||
| }, <pulumi.CustomResourceOptions>{ provider: provider }); | |||
There was a problem hiding this comment.
why do we need these casts now?
There was a problem hiding this comment.
tagging @pgavlin . It looks like we split ResourceOptions into ResourceOptions and CustomResourceOptions. This resource still takes ResourceOptions, but 'provider' is in CustomResourceOptions. So, without this cast, typescript thinks something fishy is going on.
I'm running into this because i'm pulling in a new @pulumi/pulumi version. I'm not sure what our expectation is supposed to be here.
There was a problem hiding this comment.
How close are we to landing pulumi/pulumi#1802? I think that would have let the code just work as written.
There was a problem hiding this comment.
Absent that, I think you need to write
{ providers: { aws: provider } }
There was a problem hiding this comment.
This is custom resource, not a component resource. so the { providers: { aws: provider } } version seems... wrong.
There was a problem hiding this comment.
Opened #305 to track this issue.
| @@ -0,0 +1,4 @@ | |||
| name: exoress | |||
| */ | ||
| export type Handler = (event: any, context: Context, callback: (error: any, result: any) => void) => any; | ||
| export type HandlerSignature = (event: any, context: Context, callback: (error: any, result: any) => void) => any; |
There was a problem hiding this comment.
These are exported types - changing their names is a breaking change, right?
| @@ -106,9 +129,10 @@ export class Function extends pulumi.ComponentResource { | |||
|
|
|||
| constructor(name: string, | |||
| options: FunctionOptions, | |||
| func: Handler, | |||
| func: FuncSignature, | |||
There was a problem hiding this comment.
This will, I'm nearly certain - lead to much worse intellisense - since TypeScript can't infer the signature for callers. I'm not a huge fan of losing this.
Should we consider:
- A different class that inherits from
aws.serverless.Functionthat accepts a different argument? - Moving the function parameter inside the args bag and allowing either
func:orfactory:? - Something else?
|
I agree with your concerns luke. I think to approaches can be taken here:
Because the issues seem small enough, i'm going to go with '2'. |
This is just exposing the support we added here: pulumi/pulumi#1804
Also includes an example showing how you could use this with express.