Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the .js extension to our generate closure code file. #279

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

CyrusNajmabadi
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Jul 19, 2018

Customer request from @Tirke. This enables proper .js support in the AWS cloud console:

image

Note: this will mean that any and all pulumi updates will show a change to lambdas.

@CyrusNajmabadi CyrusNajmabadi requested a review from lukehoban July 19, 2018 20:48
Copy link
Contributor

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CyrusNajmabadi CyrusNajmabadi merged commit 816ad58 into master Jul 19, 2018
@pulumi-bot pulumi-bot deleted the closureExtension branch July 19, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants