Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pulumi/pulumi to pickup codegen changes #1335

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Conversation

viveklak
Copy link
Contributor

Fixes #1321

@viveklak viveklak requested a review from stack72 January 31, 2021 21:02
@stack72
Copy link
Contributor

stack72 commented Jan 31, 2021

@viveklak is this a breaking change?

@viveklak
Copy link
Contributor Author

viveklak commented Jan 31, 2021

@viveklak is this a breaking change?

Depends.. The original breaking change was introduced in #1224 (v3.13.0). This "fixes" it by renaming a schema type which did exist before 3.13.0. This will break programs which were written against a version earlier to 3.13.0 for these resources (kinesis). Nothing written since would have compiled.

@viveklak viveklak added the impact/breaking Fixing this issue will require a breaking change label Feb 2, 2021
@viveklak
Copy link
Contributor Author

viveklak commented Feb 2, 2021

@stack72 I have verified the change shouldn't result in any resource recreation and fleshed out the changelog with more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/breaking Fixing this issue will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnalyticsApplicationOutput does not implement pulumi.Output (missing Apply method)
2 participants