Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow failure: minimal-schema #4811

Closed
pulumi-bot opened this issue Nov 21, 2024 · 2 comments
Closed

Workflow failure: minimal-schema #4811

pulumi-bot opened this issue Nov 21, 2024 · 2 comments
Assignees
@t0yv0
Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@pulumi-bot
Copy link
Contributor

Workflow Failure

minimal-schema has failed. See the list of failures below:
@pulumi-bot pulumi-bot added kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer labels Nov 21, 2024
corymhall added a commit that referenced this issue Nov 22, 2024
@corymhall
chore: generate schema-minimal as part of generate
84a9807 
re #4822, closes #4811
@corymhall corymhall mentioned this issue Nov 22, 2024
Closed
@t0yv0 t0yv0 self-assigned this Nov 25, 2024
@t0yv0 t0yv0 mentioned this issue Nov 25, 2024
Merged
@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Nov 26, 2024
t0yv0 added a commit that referenced this issue Nov 26, 2024
@t0yv0
chore: remove minimal schema from source (#4829)
ea37dae 
Keeping a copy of minimal schema (introduced in
#4587) is proving to conflict
with Pulumi tooling such as `upgrade-provider` and is not strictly
necessary. With this change the minimal schema itself as well as CI
checks to make sure it is up to date are removed. Instead it will be
computed on-the-fly by the release job as before:
 
- GitHub actions invoke this:
https://github.com/pulumi/pulumi-aws/blob/916e6f28039407d7dcb1a295c6f9e43613dd6f87/.github/workflows/build_provider.yml#L60

- Make extension ensures that this runs go generate prior to the actual
build so that the minimal schema is re-computed:
https://github.com/pulumi/pulumi-aws/blob/916e6f28039407d7dcb1a295c6f9e43613dd6f87/.mk/minimal_schema.mk#L9

Fixes:

- #4811
- #4702
@flostadler
Copy link
Contributor

Should be fixed by: #4848

@flostadler flostadler added the resolution/fixed This issue was fixed label Nov 27, 2024
@flostadler
Copy link
Contributor

Yeah, current master build is green now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0yv0 t0yv0

Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: generate schema-minimal as part of generate pulumi/pulumi-aws
3 participants
@t0yv0 @flostadler @pulumi-bot