Add option for freeing disk space #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrbradley
force-pushed
the
add-cleanup-option
branch
2 times, most recently
from
912c60b
to
a409010
Compare
|
Could you change the target branch to #942's branch. That way we will see only the diffs that this PR introduces? |
iwahbe
approved these changes
Jun 10, 2024
- Provide dedicated option instead of relying on providers to use custom steps which are run after tool installs. - Run as first step so we don't delete things that have just been installed. - Default to off to maintain existing behaviour. This can take around 3 minutes to run, so we should only run it if we're having issues.
danielrbradley
force-pushed
the
add-cleanup-option
branch
from
a409010
to
85dc371
Compare
danielrbradley
added a commit
that referenced
this pull request
Jun 12, 2024
We should honour `freeDiskSpaceBeforeTest` anywhere we previously allowed `actions.preTest` to be used. Follow-up to #964
danielrbradley
added a commit
that referenced
this pull request
Jun 12, 2024
We should honour `freeDiskSpaceBeforeTest` anywhere we previously allowed `actions.preTest` to be used. Follow-up to #964 Found while testing simplifying AWS's config using the latest changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #942
This fixes oddities in Azure and AWS where we've added steps in the
preBuildandpreTestto clear disk space but then have to install tools (e.g. dotnet) a second time as they get deleted.