Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded node package names #79

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Conversation

kmosher
Copy link
Contributor

@kmosher kmosher commented Jan 18, 2025

We don't intend to publish or reference any of these, and so therefore don't need to set any names, which are optional. This removes any confusion from scanners that these might be public packages.

Did some spot testing with the ssh-tunnel example and it still works.

@kmosher kmosher requested review from julienp and komalali January 18, 2025 02:42
"main": "./bin/index.js",
"repository": "github.com/pulumi/automation-api-examples",
"author": "EvanBoyle",
"license": "MIT",
"dependencies": {
"@pulumi/aws": "^4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, no

@kmosher kmosher merged commit 20c24a8 into main Jan 18, 2025
20 of 28 checks passed
@kmosher kmosher deleted the kmosher/remove-package-names branch January 18, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants