Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #36

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Update requirements.txt #36

merged 1 commit into from
Aug 30, 2022

Conversation

AlexMikhalev
Copy link
Contributor

Pinning markupsafe, see discussion
I had error:

jinja2/filters.py", line 13, in <module>
    from markupsafe import soft_unicode
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/alex/anaconda3/envs/pulumi_env/lib/python3.10/site-packages/markupsafe/__init__.py)

fix pip install markupsafe==2.0.1

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@RobbieMcKinstry RobbieMcKinstry added language/python kind/bug Some behavior is incorrect or out of spec impact/regression Something that used to work, but is now broken labels Aug 15, 2022
@RobbieMcKinstry RobbieMcKinstry requested review from AaronFriel and kpitzen and removed request for AaronFriel and kpitzen August 15, 2022 17:59
@RobbieMcKinstry
Copy link

If someone can repro the bug and the fix, we should merge this 👍🏻

@AaronFriel
Copy link

@kpitzen?

@dixler dixler self-assigned this Aug 30, 2022
@dixler
Copy link
Contributor

dixler commented Aug 30, 2022

looking into this. was able to repro locally and the error was resolved by the pin.

python/pulumi_over_http (git)-[main] % python app.py 
Traceback (most recent call last):
  File "/home/kdixler/go/src/github.com/pulumi/automation-api-examples/python/pulumi_over_http/app.py", line 4, in <module>
    from flask import Flask, request, make_response, jsonify
  File "/home/kdixler/go/src/github.com/pulumi/automation-api-examples/python/pulumi_over_http/venv/lib/python3.10/site-packages/flask/__init__.py", line 14, in <module>
    from jinja2 import escape
  File "/home/kdixler/go/src/github.com/pulumi/automation-api-examples/python/pulumi_over_http/venv/lib/python3.10/site-packages/jinja2/__init__.py", line 12, in <module>
    from .environment import Environment
  File "/home/kdixler/go/src/github.com/pulumi/automation-api-examples/python/pulumi_over_http/venv/lib/python3.10/site-packages/jinja2/environment.py", line 25, in <module>
    from .defaults import BLOCK_END_STRING
  File "/home/kdixler/go/src/github.com/pulumi/automation-api-examples/python/pulumi_over_http/venv/lib/python3.10/site-packages/jinja2/defaults.py", line 3, in <module>
    from .filters import FILTERS as DEFAULT_FILTERS  # noqa: F401
  File "/home/kdixler/go/src/github.com/pulumi/automation-api-examples/python/pulumi_over_http/venv/lib/python3.10/site-packages/jinja2/filters.py", line 13, in <module>
    from markupsafe import soft_unicode
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/kdixler/go/src/github.com/pulumi/automation-api-examples/python/pulumi_over_http/venv/lib/python3.10/site-packages/markupsafe/__init__.py)

@dixler dixler self-requested a review August 30, 2022 17:11
Copy link
Contributor

@dixler dixler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dixler dixler merged commit 629388f into pulumi:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec language/python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants