Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix ext-browser for new window api #58

Merged
merged 1 commit into from
Apr 26, 2024
Merged

🐛 Fix ext-browser for new window api #58

merged 1 commit into from
Apr 26, 2024

Conversation

trickypr
Copy link
Member

@trickypr trickypr commented Apr 13, 2024 •
edited
Loading

Small bug fix pr. It:

  • Removes references to the old windowApi object
  • Improves type inferance
  • Fixes a bug not caught by old type inferance

@trickypr Graphite App
Copy link
Member Author

trickypr commented Apr 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @trickypr and the rest of your teammates on Graphite Graphite

@trickypr trickypr marked this pull request as ready for review April 13, 2024 10:23
@trickypr trickypr mentioned this pull request Apr 21, 2024
Merged
@trickypr trickypr force-pushed the fix-ext-browser-new-window-api branch from b9990c5 to 28632c9 Compare April 26, 2024 04:38
@trickypr trickypr mentioned this pull request Apr 26, 2024
Draft
@trickypr Graphite App
Copy link
Member Author

trickypr commented Apr 26, 2024 •
edited
Loading

Merge activity

  • Apr 26, 1:15 AM EDT: @trickypr started a stack merge that includes this pull request via Graphite.
  • Apr 26, 1:15 AM EDT: @trickypr merged this pull request with Graphite.

@trickypr trickypr merged commit 7e02b35 into artifact-based-browser Apr 26, 2024
5 checks passed
@trickypr trickypr deleted the fix-ext-browser-new-window-api branch April 26, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trickypr