Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ First pass tab api implementation #57

Merged
merged 7 commits into from
Apr 13, 2024

Conversation

trickypr
Copy link
Member

@trickypr trickypr commented Apr 12, 2024

APIs added

  • tabs.query (partial)
  • tabs.remove
  • tabs.update
  • tabs.get
  • tabs.reload
  • tabs.forward
  • tabs.back

Infra added

  • apps/extensions/scripts/buildTypes.js: Generates typescript definitions from the schema files to ensure everything is in sync

Testing

There are basic tests for:

  • tabs.query
  • tabs.remove
  • tabs.update
  • tabs.get
  • tabs.forward
  • tabs.back

Copy link
Member Author

trickypr commented Apr 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @trickypr and the rest of your teammates on Graphite Graphite

@trickypr trickypr changed the title 🚧 Possibly functional tab query api ✨ First pass Apr 12, 2024
@trickypr trickypr changed the title ✨ First pass ✨ First pass tab api implementation Apr 12, 2024
@trickypr trickypr mentioned this pull request Apr 13, 2024
46 tasks
@trickypr trickypr linked an issue Apr 13, 2024 that may be closed by this pull request
46 tasks
@trickypr trickypr marked this pull request as ready for review April 13, 2024 09:59
Base automatically changed from extension-tests to artifact-based-browser April 13, 2024 10:00
Copy link
Member Author

Merge activity

  • Apr 13, 6:01 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@trickypr trickypr merged commit 7f3e933 into artifact-based-browser Apr 13, 2024
5 checks passed
@trickypr trickypr deleted the tab-api-part-1 branch April 13, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs
1 participant