[PR #1744/d5d149ec backport][2.20] Do not assert on a specific error message #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Once an upstream library changes its behaviour, we may observe different error messages depending on the context. This change fixes the following error: > assert "[Name or service not known]" in ctx.value.task.error["description"] E AssertionError: assert '[Name or service not known]' in 'Cannot connect to host i-am-an-invalid-url.com:80 ssl:default [None]' [noissue] (cherry picked from commit d5d149e)
git-hyagi
approved these changes
Dec 23, 2024
git-hyagi
deleted the
patchback/backports/2.20/d5d149ec8047132907a8c197692872caa8ccebc0/pr-1744
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1744 as merged into main (d5d149e).
Once an upstream library changes its behaviour, we may observe
different error messages depending on the context.
This change fixes the following error:
[noissue]