Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various issues with v2 API #1452

Closed
sivel opened this issue May 10, 2023 · 0 comments
Closed

various issues with v2 API #1452

sivel opened this issue May 10, 2023 · 0 comments
Labels
Issue Triage-Needed

Comments

@sivel
Copy link
Contributor

sivel commented May 10, 2023

Version
pulp-ansible==0.17.1
pulpcore==3.23.3

Describe the bug
I fixed a bug recently in #1432 , but had a flaw in my testing, to verify that I could then download from the v2 API.

The issues I have found are:

  1. Empty context
  2. Missing route name for v2 API for building href
  3. Incorrect download URL building

To Reproduce

Publish to v2 API, then attempt to use v2 API to get a download url

Expected behavior

I expect a functional v2 API

Additional context
I'll have a first pass pull request ready soon
sivel added a commit to sivel/pulp_ansible that referenced this issue May 10, 2023
@sivel
Fixes pulp#1452
f09eec4
sivel added a commit to sivel/pulp_ansible that referenced this issue May 15, 2023
@sivel
Address multiple v2 API issues. Fixes pulp#1452
8adc19e 
* Populate a context for use in v2 serializers
* Add name to route to satisfy v2 get_latest_version href
* Copy logic from UnpaginatedCollectionVersionSerializer.get_download_url to build a valid v2 download_url
sivel added a commit to sivel/pulp_ansible that referenced this issue May 16, 2023
@sivel
Address multiple v2 API issues. Fixes pulp#1452
7cbd882 
* Populate a context for use in v2 serializers
* Add name to route to satisfy v2 get_latest_version href
* Copy logic from UnpaginatedCollectionVersionSerializer.get_download_url to build a valid v2 download_url
sivel added a commit to sivel/pulp_ansible that referenced this issue May 17, 2023
@sivel
Address multiple v2 API issues. Fixes pulp#1452
4bbb9b7 
* Populate a context for use in v2 serializers
* Add name to route to satisfy v2 get_latest_version href
* Properly build download_url using reverse
@pulpbot pulpbot moved this to Done in RH Pulp Kanban board May 22, 2023
patchback bot pushed a commit that referenced this issue May 25, 2023
@sivel @patchback
Address multiple v2 API issues. Fixes #1452 (#1453)
c147419 
* Populate a context for use in v2 serializers
* Add name to route to satisfy v2 get_latest_version href
* Properly build download_url using reverse

(cherry picked from commit 425a4b9)
mdellweg pushed a commit that referenced this issue May 30, 2023
@patchback @sivel
Address multiple v2 API issues. Fixes #1452 (#1453) (#1470)
b038928 
* Populate a context for use in v2 serializers
* Add name to route to satisfy v2 get_latest_version href
* Properly build download_url using reverse

(cherry picked from commit 425a4b9)

Co-authored-by: Matt Martz <matt@sivel.net>
newswangerd pushed a commit to newswangerd/pulp_ansible that referenced this issue Jun 2, 2023
@patchback @sivel
Address multiple v2 API issues. Fixes pulp#1452 (pulp#1453) (pulp#1470)
a3c8e4a 
* Populate a context for use in v2 serializers
* Add name to route to satisfy v2 get_latest_version href
* Properly build download_url using reverse

(cherry picked from commit 425a4b9)

Co-authored-by: Matt Martz <matt@sivel.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue Triage-Needed
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sivel