Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-repo search cache rebuild first deletes all previous entries #1396

Closed
jctanner opened this issue Mar 22, 2023 · 0 comments · Fixed by #1399
Closed

x-repo search cache rebuild first deletes all previous entries #1396

jctanner opened this issue Mar 22, 2023 · 0 comments · Fixed by #1399
Labels
Issue Triage-Needed

Comments

@jctanner
Copy link
Contributor

jctanner commented Mar 22, 2023 •
edited
Loading

Version
head once #1357 is merged

Describe the bug
x-repo search wipes out the entire cache for a repository with no repository version before repopulating it. Clients will see no results or fewer results while the cache rebuilds. We need to enhance that behavior to retain as many entries as possible without deleting them. This also affects "performance" in the sense that an upload or a sync will take a bit longer for a cache rebuild than is absolutely necessary.

To Reproduce
Upload a CV to a repository with a distro that points at the repository instead of a repository version.
Query the search endpoint to check the total count while the upload is processing.

Expected behavior
The total count in the results should remain at a consistent level.

Additional context
jctanner added a commit to jctanner/pulp_ansible that referenced this issue Mar 23, 2023
@jctanner
Selectively delete removed content from the x-repo search index.
11521b2 
fixes: pulp#1396

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@jctanner jctanner mentioned this issue Mar 23, 2023
Merged
jctanner added a commit to jctanner/pulp_ansible that referenced this issue Mar 23, 2023
@jctanner
Use a context manager to help clean up test artifacts.
394f8ac 
fixes: pulp#1396

Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner added a commit to jctanner/pulp_ansible that referenced this issue Mar 23, 2023
@jctanner
Make artifact building optional.
d665a06 
fixes: pulp#1396

Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner added a commit to jctanner/pulp_ansible that referenced this issue Mar 23, 2023
@jctanner
Don't need to build tarballs for these tests.
eeb3640 
fixes: pulp#1396

Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner added a commit to jctanner/pulp_ansible that referenced this issue Mar 23, 2023
@jctanner
Additional test comments.
908a6af 
fixes: pulp#1396

Signed-off-by: James Tanner <tanner.jc@gmail.com>
gerrod3 pushed a commit that referenced this issue Mar 23, 2023
@jctanner
Selectively delete removed content from the x-repo search index. (#1399)
4b5d57c 
* Selectively delete removed content from the x-repo search index.

fixes: #1396

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@pulpbot pulpbot moved this to Done in RH Pulp Kanban board Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue Triage-Needed
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Selectively delete removed content from the x-repo search index. jctanner/pulp_ansible
1 participant
@jctanner