Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change date format to avoid ':' #897

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

davidtluong
Copy link
Contributor

@davidtluong davidtluong commented Mar 2, 2023

Change date format to avoid : character. Some filesystems do not allow for this.

Fixes: https://issues.redhat.com/browse/AAP-9250

@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2023

Hi @rh-dluong. Thanks for your PR.

I'm waiting for a pulp member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidtluong
Copy link
Contributor Author

@fao89 Does anything else need to be done to move this forward?

@fao89
Copy link
Member

fao89 commented Apr 4, 2023

@fao89 Does anything else need to be done to move this forward?

@git-hyagi is the maintainer now

@git-hyagi
Copy link
Collaborator

Please, rebase your pr.
Yesterday we fixed some issues in CI, so now we can check if the failing jobs will get green.

@openshift-ci openshift-ci bot removed the lgtm label Apr 12, 2023
@davidtluong davidtluong force-pushed the adjust-date-format branch 2 times, most recently from cebc5e4 to 017acde Compare April 12, 2023 14:40
@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, git-hyagi, rh-dluong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Apr 12, 2023
@git-hyagi
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 12, 2023
@git-hyagi git-hyagi merged commit d4a6406 into pulp:ansible Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants