Make addCustomPulpSettings function more "generic" #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: git-hyagi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
git-hyagi
commented
Nov 3, 2023
Comment on lines
-171
to
-172
| GALAXY_COLLECTION_SIGNING_SERVICE = "ansible-default" | ||
| GALAXY_CONTAINER_SIGNING_SERVICE = "container-default" |
There was a problem hiding this comment.
Removing these from default settings because:
1- these configs are not used in pulp deployments
2- the metadata signing is not working yet (pending fix #939)
git-hyagi
force-pushed
the
fix-dict-pulp-settings
branch
from
46e94a9 to
c2a3490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1132
Thank you for your contribution!
If your PR needs a changelog entry:
If not, please add
[noissue]to your commit message