Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] There is no reconciliation for the "pulp-redirect" ingress in OCP clusters #918

Closed
git-hyagi opened this issue Mar 27, 2023 · 0 comments · Fixed by #1009
Closed

[BUG] There is no reconciliation for the "pulp-redirect" ingress in OCP clusters #918

git-hyagi opened this issue Mar 27, 2023 · 0 comments · Fixed by #1009
Labels
bug Something isn't working

Comments

@git-hyagi
Copy link
Collaborator

Describe the bug
The "pulp-redirect" ingress resource does not have a reconciliation logic defined. The operator is deploying it but never checking if it has been modified:
https://github.com/pulp/pulp-operator/blob/main/controllers/repo_manager/ingress.go#L359

To Reproduce
Steps to reproduce the behavior:
Install the operator in an OCP cluster and define Pulp CR with

ingress_type: ingress
ingress_class_name:  openshift-default

wait until the operator finishes its execution, modify the "pulp-redirect" ingress and the controller will not trigger a reconciliation.
@git-hyagi git-hyagi added bug Something isn't working Triage-Needed labels Mar 27, 2023
git-hyagi added a commit to git-hyagi/pulp-operator that referenced this issue Jul 18, 2023
@git-hyagi
Do not get ingress default domain and ingressclass
444cb3e 
After a discussion, the team decided that would be better
to remove the ingress class checks and also automatically
collecting the default ingress domain because they would
need cluster roles.
fixes pulp#885
fixes pulp#917
fixes pulp#918
fixes pulp#923
@git-hyagi git-hyagi mentioned this issue Jul 18, 2023
Merged
openshift-merge-robot pushed a commit that referenced this issue Jul 18, 2023
@git-hyagi @openshift-merge-robot
Do not get ingress default domain and ingressclass
d21b05d 
After a discussion, the team decided that would be better
to remove the ingress class checks and also automatically
collecting the default ingress domain because they would
need cluster roles.
fixes #885
fixes #917
fixes #918
fixes #923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not get ingress default domain and ingressclass git-hyagi/pulp-operator
2 participants
@mikedep333 @git-hyagi