-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voter Macros #25
Voter Macros #25
Conversation
Lynx005F
commented
Jun 10, 2024
- Added fault detection only voters
- Added single-line voting macros
- Macros instantiate voter cells (so they could easily be replaced with technology-specific cells)
- Macros automatically uniquely name underlying voter cells
- Macros usable with bender unclude
- Added testbenches for above functionality
- Updated README.md accordingly
…some cells needed for voters).
d57c1e1
to
bccb2a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fixes but LGTM
9a0cbbd
to
42be33b
Compare
- Updated licence - Added $fatal for unsupported replicas - Made parameterizable voter macros have explicit parameter. - Updated README.md
214a2a3
to
726ac10
Compare
I managed to also fix the enum errors that previously needed to be supressed by using an index into an array. Now all enums with >1 bit width work without errors, but Enums with 1 bit only are now unsupported (I think it is fine as one can just use logic instead). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few more minor issues, some more critical than others.
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
…uration and set fault_any to 0 when unused.
IMO we can squash all comits without loosing any relevant history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Added voter macros which automatically instantiate unique cells (and some cells needed for voters). Co-authored-by: Maurus Item <itemm@student.ethz.ch> Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>