Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voter Macros #25

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Conversation

Lynx005F
Copy link
Contributor

  • Added fault detection only voters
  • Added single-line voting macros
    • Macros instantiate voter cells (so they could easily be replaced with technology-specific cells)
    • Macros automatically uniquely name underlying voter cells
    • Macros usable with bender unclude
  • Added testbenches for above functionality
  • Updated README.md accordingly

@Lynx005F Lynx005F force-pushed the itemm/cell_voter_macros branch from d57c1e1 to bccb2a9 Compare June 10, 2024 10:30
@Lynx005F Lynx005F marked this pull request as ready for review June 11, 2024 09:27
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes but LGTM

@Lynx005F Lynx005F force-pushed the itemm/cell_voter_macros branch from 9a0cbbd to 42be33b Compare June 11, 2024 13:05
Maurus Item added 2 commits June 11, 2024 15:13
- Updated licence
- Added $fatal for unsupported replicas
- Made parameterizable voter macros have explicit parameter.
- Updated README.md
@Lynx005F Lynx005F force-pushed the itemm/cell_voter_macros branch from 214a2a3 to 726ac10 Compare June 11, 2024 13:13
@Lynx005F Lynx005F requested a review from micprog June 14, 2024 07:27
@Lynx005F
Copy link
Contributor Author

I managed to also fix the enum errors that previously needed to be supressed by using an index into an array. Now all enums with >1 bit width work without errors, but Enums with 1 bit only are now unsupported (I think it is fine as one can just use logic instead).

Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few more minor issues, some more critical than others.

Lynx005F and others added 5 commits June 19, 2024 07:10
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
…uration and set fault_any to 0 when unused.
@Lynx005F
Copy link
Contributor Author

IMO we can squash all comits without loosing any relevant history

Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@micprog micprog merged commit 71e7066 into pulp-platform:master Jun 19, 2024
2 checks passed
Lynx005F added a commit to Lynx005F/redundancy_cells that referenced this pull request Nov 4, 2024
* Added voter macros which automatically instantiate unique cells (and some cells needed for voters).

Co-authored-by: Maurus Item <itemm@student.ethz.ch>
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants