-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tiling Support to All CCT Kernels and Fix CCT Operators on Siracusa Platform for L2 #35
Conversation
740cf47
to
cd2ee51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Run, great PR addressing lots of issues and building strong ground for every fp execution on PULPOpen! A few comments to address but no critical ones.
Signed-off-by: Victor Jung <33875047+Victor-Jung@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the interface that you used (CodeGenVerbosity
) but I don't like that the pass is in the PULPTiling pass. A small change and this will roll.
9624c91
to
178741f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing my comments!
…sa Platform for L2 (pulp-platform#35) * Update CCT onnx without broadcast and Upload CCT two version(16,32) * Update CCT on PULP with Tiling --------- Co-authored-by: Victor Jung <33875047+Victor-Jung@users.noreply.github.com> Update CCT on PULP with Tiling Add PULPProfileUntiled Pass
…sa Platform for L2 (pulp-platform#35) * Update CCT onnx without broadcast and Upload CCT two version(16,32) * Update CCT on PULP with Tiling --------- Co-authored-by: Victor Jung <33875047+Victor-Jung@users.noreply.github.com>
…sa Platform for L2 (pulp-platform#35) * Update CCT onnx without broadcast and Upload CCT two version(16,32) * Update CCT on PULP with Tiling --------- Co-authored-by: Victor Jung <33875047+Victor-Jung@users.noreply.github.com> Update CCT on PULP with Tiling Add PULPProfileUntiled Pass
…sa Platform for L2 (pulp-platform#35) * Update CCT onnx without broadcast and Upload CCT two version(16,32) * Update CCT on PULP with Tiling --------- Co-authored-by: Victor Jung <33875047+Victor-Jung@users.noreply.github.com> Update CCT on PULP with Tiling Add PULPProfileUntiled Pass
Description
This update improves CCT's kernel tiling support and resolves multiple operator issues on the Siracusa platform. The new kernel templates for convolution and max-pooling enhance padding integration while adopting an HWC layout. Additionally, key constraints for tiling have been introduced, fixing several execution issues in GEMM, MatMul, and float-based computations. The layers has also been refined to handle bias broadcasting correctly, ensuring accurate output shape inference.
Added
Float Bindings, Tilers for Pulp Target
Float Convolution, MaxPool Parser, Template, Kernel
Tiling Constraints
conv
gather
andlayernorm
and exisitng constraints for other kernels.Fixed
CycleMeasure Pass for Siracusa Untiling Profilling
GEMM Tiling Constraints Issue
transA
and `transB' not supported.MatMul Multi-Dimensional Input Issue
Add Layer for Broadcasted Bias
float32
withf
causedinf
errors.Changed
add
andgemm
to avoid unnecessary broadcasting.PR Merge Checklist
devel
commit and pointing todevel
.CHANGELOG.md
file has been updated.