Fix panic while getting byte outside char boundary

pulldown-cmark · Aug 3, 2017 · a2b8d17 · a2b8d17
1 parent 5277ba2
commit a2b8d17
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/parse.rs b/src/parse.rs
@@ -755,8 +755,8 @@ impl<'a> RawParser<'a> {
             if self.off + 1 + beg_tag.len() < self.text.len() &&
                self.text[self.off + 1..].starts_with(&beg_tag[..]) {
                 let pos = self.off + beg_tag.len() + 1;
-                let s = &self.text[pos..pos + 1];
-                if s == " " || s == "\n" || s == ">" {
+                let s = self.text.as_bytes()[pos];
+                if s == b' ' || s == b'\n' || s == b'>' {
                     return Some(end_tag);
                 }
             }

diff --git a/tests/errors.rs b/tests/errors.rs
@@ -27,3 +27,12 @@ fn test_infinite_loop() {
     let parser = Parser::new(&markdown);
     for _ in parser { }
 }
+
+#[test]
+fn test_html_tag() {
+    let markdown = "<script\u{feff}";
+    use pulldown_cmark::Parser;
+
+    let parser = Parser::new(&markdown);
+    for _ in parser { }
+}