-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created a Category model #4
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good progress! I left some suggestions inline.
|
||
get "/new_categories", to: "categories#new_categories" | ||
|
||
resources :categories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need the other 2 get
routes if you have this one. reference: https://guides.rubyonrails.org/routing.html#resource-routing-the-rails-default
name: MyString | ||
|
||
two: | ||
name: MyString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want your test fixtures to have different values, if at some point you use them.
require "test_helper" | ||
|
||
class CategoriesControllerTest < ActionDispatch::IntegrationTest | ||
# test "the truth" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that there aren't any tests, make sure you run the application in development and can actually create a category from the app's web UI.
advances #2