Changed the link for the how to submit and deleted unused code (#670)

pulibrary · Aug 16, 2024 · bad30a1 · bad30a1
1 parent 23c670c
commit bad30a1
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 58 deletions.
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb
@@ -5,8 +5,6 @@ def about; end
 
   def features; end
 
-  def submit; end
-
   def policies; end
 
   def contributors; end

diff --git a/app/views/home/submit.html.erb b/app/views/home/submit.html.erb
diff --git a/app/views/shared/_nav_links.html.erb b/app/views/shared/_nav_links.html.erb
@@ -2,5 +2,5 @@
   <li class="nav-item"><a class="nav-link" href="<%= root_path %>">Home</a></li>
   <li class="nav-item"><a class="nav-link" href="<%= home_about_path %>">About</a></li>
   <li class="nav-item"><a class="nav-link" href="<%= home_features_path %>">Features</a></li>
-  <li class="nav-item"><a class="nav-link" href="<%= home_submit_path %>">How to Submit</a></li>
+  <li class="nav-item"><a class="nav-link" href="https://datacommons.princeton.edu/describe/" target="_blank">How to Submit</a></li>
 </ul>
diff --git a/config/routes.rb b/config/routes.rb
@@ -38,7 +38,6 @@
 
   get 'about' => 'home#about', as: :home_about
   get 'features' => 'home#features', as: :home_features
-  get 'submit' => 'home#submit', as: :home_submit
   get 'policies' => 'home#policies', as: :home_policies
   get 'contributors' => 'home#contributors', as: :home_contributors
 

diff --git a/spec/requests/static_spec.rb b/spec/requests/static_spec.rb
@@ -6,9 +6,4 @@
     get "/about"
     expect(response).to have_http_status(:success)
   end
-
-  it "has a how to submit page" do
-    get "/submit"
-    expect(response).to have_http_status(:success)
-  end
 end
diff --git a/spec/system/front_page_spec.rb b/spec/system/front_page_spec.rb
@@ -27,7 +27,7 @@
       visit '/'
       expect(page).to have_link "Home", href: "/"
       expect(page).to have_link "About", href: "/about"
-      expect(page).to have_link "How to Submit", href: "/submit"
+      expect(page).to have_link "How to Submit", href: "https://datacommons.princeton.edu/describe/"
       expect(page).to have_link "Accessibility", href: "https://accessibility.princeton.edu/help"
     end
   end