Skip to content

Commit

Permalink
Fix link to digitization requests (#4128)
Browse files Browse the repository at this point in the history
* Fix link to digitization requests

* Fixed test

* Fix rspec test

---------

Co-authored-by: Ryan Laddusaw <rladdusaw@princeton.edu>
  • Loading branch information
rladdusaw and Ryan Laddusaw authored Aug 20, 2024
1 parent b6a5353 commit 7597153
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const accountChildren = computed(() => {
return [
{name: 'Library Account', component: 'Alma', href: '/users/sign_in?origin=%2Fredirect-to-alma', target: '_blank'},
{name: 'Bookmarks', unsafe_name: bookmarksHtml.value, component: 'Bookmarks', href: '/bookmarks/'},
{name: "ILL & Digitization Requests", component: 'ILL', href: '/digitization_requests/'},
{name: "ILL & Digitization Requests", component: 'ILL', href: '/account/digitization_requests/'},
{name: 'Search History', component: 'History', href: '/search_history/'},
{name: 'Log Out', component: 'LogOut', href: '/sign_out/'},
];
Expand Down
2 changes: 1 addition & 1 deletion spec/features/login_account_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
link = find_link("Library Account")
expect(link[:href]).to include login_and_redirect_to_alma_url
expect(link[:target]).to eq("_blank")
expect(page).to have_link("ILL & Digitization Requests", href: '/digitization_requests/')
expect(page).to have_link("ILL & Digitization Requests", href: '/account/digitization_requests/')
expect(page).to have_link("Bookmarks (0)", href: '/bookmarks/')
expect(page).to have_link("Search History", href: '/search_history/')
expect(page).to have_link("Log Out")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ describe('OrangelightHeader', () => {
);
expect(accountLink.text()).toEqual('Library Account');

const digitizationLink = wrapper.get('a[href="/digitization_requests/"]');
const digitizationLink = wrapper.get(
'a[href="/account/digitization_requests/"]'
);
expect(digitizationLink.text()).toEqual('ILL & Digitization Requests');

const bookmarksLink = wrapper.get('a[href="/bookmarks/"]');
Expand Down

0 comments on commit 7597153

Please sign in to comment.