Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create docker container. #217

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Create docker container. #217

merged 14 commits into from
Sep 23, 2024

Conversation

tpendragon
Copy link
Contributor

@tpendragon tpendragon commented Sep 12, 2024 •
edited by hackartisan
Loading

Commands run (no changes):

  1. bundle add dockerfile-rails --optimistic --group development
  2. bin/rails generate dockerfile --nginx --parallel
  3. rm -rf .yarn
  4. rm .yarnrc
  5. Copy build+publish action from DPUL-C

Extra things:

  1. Copy and adjust config/deploy/staging.hcl from DPUL-C
  2. Create and run [Imagecat] Run on Nomad princeton_ansible#5336
  3. Create and git add --force tmp/pids/.keep
  4. Create a docker-compose file for testing the Dockerfile locally.
  5. Adjust README.

I also updated ruby because the container that ran Ruby 3.2.0 had so many vulnerabilities it wouldn't fit into a github comment.

@tpendragon
Create docker container.
ba6b917 
Commands run (no changes):

1. `bundle add dockerfile-rails --optimistic --group development`
1. `bin/rails generate dockerfile --nginx --parallel`
1. `rm -rf .yarn`
1. `rm .yarnrc`
1. Copy build+publish action from DPUL-C
@tpendragon
Rubocop.
9cd37c0
@tpendragon
Too many vulns, use a more recent image.
186c9b6
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Container Scanning Status: ✅ Success


ghcr.io/pulibrary/imagecat-rails:pr-217 (debian 12.7)
=====================================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@tpendragon
Add docker compose.
95ba106 
There was a missing pids directory that was necessary for launching -
this docker-compose file let me debug that.
@tpendragon tpendragon marked this pull request as ready for review September 20, 2024 20:35
@tpendragon tpendragon merged commit 5aad445 into main Sep 23, 2024
6 checks passed
@tpendragon tpendragon deleted the docker-nomad branch September 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackartisan hackartisan hackartisan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpendragon @hackartisan