SharedWorker refactor
#471
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple and re-organize `SharedWorker` code for better maintainability. perf(shared-worker): improved subscription state refresh logic Additional query parameter (removed before sending) is added for requests triggered by user and state will be updated only for these requests. refactor(logger): avoid similar timestamp in sequential lines Log entry timestamp will be altered on millisecond if multiple log entries have similar timestamp (logged in fraction of nanoseconds).
parfeon
added
priority: medium
⛔ Snyk checks have failed. 1 issues have been found so far.
⛔ security/snyk check is complete. 1 issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) 💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mohitpubnub
reviewed
Aug 7, 2025
| if (channelGroups) channelGroups = channelGroups.filter((channelGroup) => !channelGroup.endsWith('-pnpres')); | ||
| if (channels) channels = channels.filter((channel) => !channel.endsWith('-pnpres')); | ||
| } | ||
| if (channelGroups) channelGroups = channelGroups.filter((channelGroup) => !channelGroup.endsWith('-pnpres')); |
There was a problem hiding this comment.
will this be applicable to ee and non ee case both cases? OR it's just for getSubscribedChannels/Groups method?
There was a problem hiding this comment.
This used for REST API call itself. Function used by: SubscriptionManager, PresenceEventEngine and EventEngine (when presence interval not set).
|
with latest build test running 2 hours, looks fine |
|
@mohitpubnub sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(shared-worker): reorganize
SharedWorkercodeDecouple and re-organize
SharedWorkercode for better maintainability.perf(shared-worker): improved subscription state refresh logic
Additional query parameter (removed before sending) is added for requests triggered by user and state will be updated only for these requests.
refactor(logger): avoid similar timestamp in sequential lines
Log entry timestamp will be altered on millisecond if multiple log entries have similar timestamp (logged in fraction of nanoseconds).