Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/#672_add_tabs_for_different_types_of_requirement #684

Conversation

rizaardiyanto1412
Copy link
Contributor

Description

Add tabs on Checklists screen.

Benefits

Solved #672

Possible drawbacks

Applicable issues

#672

Checklist

  • I have created a specific branch for this pull request before committing, starting off the current HEAD of development branch.
  • I'm submitting to the development, feature/hotfix/release branch. (Do not submit to the master branch!)
  • This pull request relates to a specific problem (bug or improvement).
  • I have mentioned the issue number in the pull request description text.
  • All the issues mentioned in this pull request relate to the problem I'm trying to solve.
  • The code I'm sending follows the PSR-12 coding style.

@rizaardiyanto1412 rizaardiyanto1412 linked an issue Jul 11, 2024 that may be closed by this pull request
@olatechpro olatechpro requested review from richaferry and removed request for olatechpro July 18, 2024 09:06
@richaferry richaferry changed the title Features/#672 add tabs for different types of requirement feature/#672_add_tabs_for_different_types_of_requirement Jul 26, 2024
Copy link
Collaborator

@richaferry richaferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed 1 file. please also help to add this file core/Requirement/External_links.php @rizaardiyanto1412

@rizaardiyanto1412
Copy link
Contributor Author

@richaferry I added external links now. However I noticed something weird where external link is not present. I create new GitHub issue on it: #710

@richaferry richaferry merged commit 1f9af47 into development Jul 30, 2024
3 checks passed
@richaferry richaferry deleted the features/#672_add_tabs_for_different_types_of_requirement branch July 30, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tabs for different types of requirement
2 participants