Merge pull request #716 from publishpress/release-2.12

Release 2.12

.github/ISSUE_TEMPLATE/release-pro-plugin.md

@@ -23,7 +23,7 @@ To release the Pro plugin, ensure you complete all the tasks below.
 - [ ] Update the `.pot` file executing `composer gen:pot` or `loco translate plugin` and include a note in the changelog.
 - [ ] Especially for minor and patch releases, maintain backward compatibility for changes like renamed or moved classes, namespaces, functions, etc. Include deprecation comments and mention this in the changelog. Major releases may remove deprecated code, but always note this in the changelog.
 - [ ] Revise the changelog to include all changes with user-friendly descriptions and ensure the release date is accurate.
--- [ ] Update the version number in the main plugin file and `readme.txt`, adhering to specifications from our [tech documentation](https://rambleventures.slab.com/posts/version-numbers-58nmrk4b), and commit to the release branch.
+- [ ] Update the version number in the main plugin file and `readme.txt`, adhering to specifications from our [tech documentation](https://rambleventures.slab.com/posts/version-numbers-58nmrk4b), and commit to the release branch.
 - [ ] Confirm there are no uncommitted changes.
 - [ ] Build the zip package with `composer build`, creating a new package in the `./dist` directory.
 - [ ] Distribute the new package to the team for testing.

.github/workflows/phplint.yml

@@ -14,7 +14,7 @@ jobs:
     - name: Setup PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '7.4'
+        php-version: '8.0'
         extensions: intl
       env:
         COMPOSER_TOKEN: ${{ secrets.COMPOSER_TOKEN }}

.gitignore

@@ -6,6 +6,7 @@
 .idea
 
 # Build Artifacts
+/build
 /dist
 
 # Dependencies
@@ -22,6 +23,7 @@ wpcom-helper.php
 CONTRIBUTING.md
 builder.yml
 .env.testing
+/bin
 /local.sh
 /packages
-/lib/**/.git
+/lib/**/.git

.prettierrc

@@ -1,16 +1,16 @@
 {
-  "printWidth": 120,
-  "tabWidth": 2,
-  "useTabs": false,
-  "semi": true,
-  "singleQuote": true,
-  "quoteProps": "as-needed",
-  "jsxSingleQuote": false,
-  "trailingComma": "all",
-  "bracketSpacing": true,
-  "jsxBracketSameLine": false,
-  "arrowParens": "always",
-  "proseWrap": "preserve",
-  "htmlWhitespaceSensitivity": "css",
-  "endOfLine": "lf"
+    "printWidth": 120,
+    "tabWidth": 4,
+    "useTabs": false,
+    "semi": true,
+    "singleQuote": true,
+    "quoteProps": "as-needed",
+    "jsxSingleQuote": false,
+    "trailingComma": "all",
+    "bracketSpacing": true,
+    "jsxBracketSameLine": false,
+    "arrowParens": "always",
+    "proseWrap": "preserve",
+    "htmlWhitespaceSensitivity": "css",
+    "endOfLine": "lf"
 }

composer.json

@@ -15,8 +15,7 @@
   "repositories": [
   ],
   "require": {
-    "php": ">=7.2.5",
-    "publishpress/wordpress-banners": "^1.3"
+    "php": ">=7.2.5"
   },
   "require-dev": {
     "codeception/module-asserts": "^1.2",

core/Requirement/Approved_by.php

@@ -22,6 +22,13 @@ class Approved_by extends Base_multiple implements Interface_required
      */
     public $name = 'approved_by';
 
+    /**
+     * The name of the group, used for the tabs
+     * 
+     * @var string
+     */
+    public $group = 'content';
+
     protected $field_name = 'roles';
 
     const POST_META_PREFIX = 'pp_checklist_custom_item';

core/Requirement/Base_multiple.php

@@ -104,9 +104,10 @@ public function get_setting_field_html($css_class = '')
         }
 
         $html .= sprintf(
-            '<select id="%s" name="%s" multiple="multiple">',
+            '<select id="%s" name="%s" class="%s" multiple="multiple">',
             $id,
-            $name
+            $name,
+            $css_class
         );
 
         $labels = $this->get_setting_drop_down_labels();

core/Requirement/Categories_count.php

@@ -25,6 +25,13 @@ class Categories_count extends Base_counter
      */
     public $name = 'categories_count';
 
+     /**
+     * The name of the group, used for the tabs
+     * 
+     * @var string
+     */
+    public $group = 'categories';
+
     /**
      * @var int
      */

core/Requirement/Custom_item.php

@@ -24,6 +24,7 @@ class Custom_item extends Base_multiple implements Interface_required
      */
     protected $title;
 
+
     /**
      * The constructor. It adds the action to load the requirement.
      *
@@ -38,6 +39,7 @@ public function __construct($name, $module, $post_type)
         $this->name      = trim((string)$name);
         $this->is_custom = true;
         $this->field_name = 'editable_by';
+        $this->group     = 'custom';
 
         parent::__construct($module, $post_type);
     }

core/Requirement/External_links.php

@@ -21,6 +21,13 @@ class External_links extends Base_counter
      */
     public $name = 'external_links';
 
+     /**
+     * The name of the group, used for the tabs
+     * 
+     * @var string
+     */
+    public $group = 'links';
+
     /**
      * @var int
      */

core/Requirement/Featured_image.php

@@ -20,6 +20,13 @@ class Featured_image extends Base_simple
      */
     public $name = 'featured_image';
 
+    /**
+     * The name of the group, used for the tabs
+     * 
+     * @var string
+     */
+    public $group = 'images';
+
     /**
      * @var int
      */

core/Requirement/Featured_image_alt.php

@@ -20,10 +20,17 @@ class Featured_image_alt extends Base_simple
      */
     public $name = 'featured_image_alt';
 
+    /**
+     * The name of the group, used for the tabs
+     * 
+     * @var string
+     */
+    public $group = 'images';
+
     /**
      * @var int
      */
-    public $position = 110;
+    public $position = 150;
 
     /**
      * Initialize the language strings for the instance

core/Requirement/Filled_excerpt.php

@@ -20,6 +20,13 @@ class Filled_excerpt extends Base_counter
      */
     public $name = 'filled_excerpt';
 
+     /**
+     * The name of the group, used for the tabs
+     * 
+     * @var string
+     */
+    public $group = 'content';
+
     /**
      * @var int
      */

core/Requirement/Image_alt.php

@@ -21,6 +21,13 @@ class Image_alt extends Base_simple
      */
     public $name = 'image_alt';
 
+    /**
+     * The name of the group, used for the tabs
+     * 
+     * @var string
+     */
+    public $group = 'images';
+
     /**
      * @var int
      */

core/Requirement/Internal_links.php

@@ -21,6 +21,13 @@ class Internal_links extends Base_counter
      */
     public $name = 'internal_links';
 
+     /**
+     * The name of the group, used for the tabs
+     * 
+     * @var string
+     */
+    public $group = 'links';
+
     /**
      * @var int
      */