-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update routes_test.rb #899
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Hi @cmcgee0308, can you add a link to the issue?
|
#858 Sorry about that! I also see that there seems to be an error? How do I go about fixing this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cmcgee0308. Great job!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thank you @TildaDares ! Is it okay to ask what exactly this issue does or what the lines I put in do? I've never worked with code like this before. |
@cmcgee0308 The code you’ve just added is a routes test. It basically tests that a route maps to the correct controller action. If you’d like to know more, you can read the Rails docs on route testing https://api.rubyonrails.org/v7.0.2.2/classes/ActionDispatch/Assertions/RoutingAssertions.html I hope that helps |
Thank you @TildaDares I appreciate it! |
Fixes #(update with issue number)
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake test
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
Thanks!