Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routes_test.rb #899

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Update routes_test.rb #899

merged 2 commits into from
Mar 7, 2022

Conversation

cmcgee0308
Copy link
Contributor

Fixes #(update with issue number)

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Mar 5, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as
the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Mar 5, 2022

@TildaDares
Copy link
Member

Hi @cmcgee0308, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

@cmcgee0308
Copy link
Contributor Author

#858 Sorry about that! I also see that there seems to be an error? How do I go about fixing this?

@TildaDares TildaDares linked an issue Mar 7, 2022 that may be closed by this pull request
5 tasks
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmcgee0308. Great job!

@TildaDares TildaDares merged commit 2806528 into publiclab:main Mar 7, 2022
@welcome
Copy link

welcome bot commented Mar 7, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@cmcgee0308
Copy link
Contributor Author

Thank you @TildaDares ! Is it okay to ask what exactly this issue does or what the lines I put in do? I've never worked with code like this before.

@TildaDares
Copy link
Member

TildaDares commented Mar 7, 2022

@cmcgee0308 The code you’ve just added is a routes test. It basically tests that a route maps to the correct controller action. If you’d like to know more, you can read the Rails docs on route testing https://api.rubyonrails.org/v7.0.2.2/classes/ActionDispatch/Assertions/RoutingAssertions.html

I hope that helps

@cmcgee0308
Copy link
Contributor Author

Thank you @TildaDares I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add routes test for spectrums/anonymous
2 participants