-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created drafts page #9893
created drafts page #9893
Conversation
Code Climate has analyzed commit 56c3e6e and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9893 +/- ##
==========================================
+ Coverage 78.24% 82.13% +3.89%
==========================================
Files 98 98
Lines 5947 5957 +10
==========================================
+ Hits 4653 4893 +240
+ Misses 1294 1064 -230
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TildaDares wow this looks great! 🎉 The responsive design and all the tests 💯
Maybe we can have the route under notes only like notes/drafts
but this is just my suggestion @jywarren can comment better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, good job @TildaDares! 🎉
Aside from @Tlazypanda's suggestion which makes sense...I think the PR is good to go 🚀
@TildaDares Looks good to me! Great work! |
@Tlazypanda @RuthNjeri You're right about using the |
whoa... codecov had been a bit broken. Maybe they introduced a new system upstream to fix that but it came with some additional features or settings defaults? |
Looks awesome. Thanks @TildaDares !!!!! |
Fixes #9660
Part of larger planning issue in #9667
Responsiveness
Screen.Recording.2021-07-09.at.00.21.38.mov
When a user who is neither a moderator or the drafts author tries to visit the drafts page, a flash notice is displayed and the user is redirected to the homepage