-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Test for React Edit Comment #9713
Conversation
@@ -247,28 +276,6 @@ def get_path(page_type, path) | |||
assert_selector('.btn[data-original-title="Help"]', count: 1) | |||
end | |||
|
|||
test "#{page_type_string}: edit comment" do | |||
nodes(node_name).add_comment({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting this system test, as it's replaced by the new one.
Code Climate has analyzed commit ed41c83 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9713 +/- ##
=======================================
Coverage ? 82.01%
=======================================
Files ? 98
Lines ? 5928
Branches ? 0
=======================================
Hits ? 4862
Misses ? 1066
Partials ? 0 |
This looks awesome. Thanks @noi5e! I did want to note i saw a warning in the Jenkins build log:
I want to say i don't think anything broke, but just noting in case it's an issue to look out for. |
Looks awesome. Merged! Pls give it a spin at https://stable.publiclab.org once it builds -- thanks a ton, @noi5e !!! |
@jywarren: A little more about that error that you mentioned also here
This is occurring because webpacker is trying to parse webpacker encounters It's a minor thing and low-priority IMO, but would be good to take care of down the line. The webpacker config needs to be altered. I'll put it on my to-do. |
Thank you this makes total sense. 💫💫💫 |
* add edit/delete class for button publiclab#9365 * add test for edit comment publiclab#9365
* add edit/delete class for button publiclab#9365 * add test for edit comment publiclab#9365
Part of the React rewrite of the comment system. See #9365
Added system test for editing comments that handles both React and Rails comment systems.
Also tweaked the
CommentToolbarButton
component so that it displays a class foredit-comment-btn
s(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)