Change #dropzone-large ID to #comment-form-body #9123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #9123 +/- ##
=======================================
Coverage ? 82.00%
=======================================
Files ? 100
Lines ? 5931
Branches ? 0
=======================================
Hits ? 4864
Misses ? 1067
Partials ? 0 |
|
Tests are passing, but hold off on merging this one for now! I'm going to write a system test for toggling preview. Also, this PR has a bunch of prerequisites! Visit my planning issue at #9069 and merge the PRs from top to bottom please! |
noi5e
commented
Feb 3, 2021
| @@ -69,12 +69,12 @@ $(function() { | |||
| console.log($("#image-upload-progress-container-" + $E.commentFormID)); | |||
| $("#image-upload-progress-container-" + $E.commentFormID).show(); | |||
| $("#image-upload-text-" + $E.commentFormID).show(); | |||
| $("#dropzone-choose-one-" + $E.commentFormID).hide(); | |||
| $("#choose-one-" + $E.commentFormID).hide(); | |||
There was a problem hiding this comment.
removing the dropzone part in the ID slug. choose one is already nested in another, larger dropzone, which I forgot, so this isn't necessary.
|
Code Climate has analyzed commit 99da9a6 and detected 0 issues on this pull request. View more on Code Climate. |
jywarren
approved these changes
Feb 4, 2021
|
Awesome! Thanks both of you!!!! |
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* merge branches publiclab#9104 publiclab#9107 publiclab#9108 publiclab#9110 publiclab#9118 * change #dropzone-large ID to #comment-form-body * add comprehensive preview button test
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* merge branches publiclab#9104 publiclab#9107 publiclab#9108 publiclab#9110 publiclab#9118 * change #dropzone-large ID to #comment-form-body * add comprehensive preview button test
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* merge branches publiclab#9104 publiclab#9107 publiclab#9108 publiclab#9110 publiclab#9118 * change #dropzone-large ID to #comment-form-body * add comprehensive preview button test
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* merge branches publiclab#9104 publiclab#9107 publiclab#9108 publiclab#9110 publiclab#9118 * change #dropzone-large ID to #comment-form-body * add comprehensive preview button test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix, this is fixing this inconsistency mentioned here in this comment
In the past, when we hit the Preview button on a comment form, the editor toggled on B in the above image, which had the class
.dropzone. This is a little difficult to read in the code (as mentioned in the comment linked above). B being a.dropzonehas nothing to do with us toggling it for preview. So I changed the ID to#comment-form-body-reply-123(used to be#dropzone-large-reply-123), and toggle on that instead.Also changed the ID to
#comment-form-bodyin the edit form partial (used to be#c123div), and updated system tests.(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)