Add Unique Preview Button IDs #9012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
noi5e
commented
Jan 15, 2021
| @@ -123,25 +123,17 @@ $E = { | |||
| generate_preview: function(id,text) { | |||
| $('#'+id)[0].innerHTML = marked(text) | |||
| }, | |||
| toggle_preview: function (comment_id = null) { | |||
| toggle_preview: function() { | |||
There was a problem hiding this comment.
I searched through plots2: it seems as if toggle_preview is never called with a comment_id parameter. I could be wrong about that(?) For now, I am deleting this unused code.
There was a problem hiding this comment.
Hmm, and comment previews are toggled with a different method? Ok!
noi5e
commented
Jan 15, 2021
| @@ -208,7 +208,7 @@ en: | |||
| preview_topics: "This preview is not yet published and is not part of any topics yet." | |||
| _comments: | |||
| comments: "Comments" | |||
| post_comment: "Post comment" | |||
| post_comment: "Post Comment" | |||
| post_placeholder: "Help the author refine their post, or point them at other | |||
There was a problem hiding this comment.
This is a small thing, but I noticed this when writing system tests.
Codecov Report
@@ Coverage Diff @@
## main #9012 +/- ##
=======================================
Coverage ? 82.03%
=======================================
Files ? 100
Lines ? 5933
Branches ? 0
=======================================
Hits ? 4867
Misses ? 1066
Partials ? 0 |
jywarren
approved these changes
Jan 15, 2021
sagarpreet-chadha
approved these changes
Jan 15, 2021
|
Code Climate has analyzed commit 373f349 and detected 0 issues on this pull request. View more on Code Climate. |
|
Tests are passing now (they were referring to the old IDs and classes). Ready to merge! |
|
Merging now...thanks evreyone 🎉 |
noi5e
changed the title
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* rename method for making comment element IDs * add unique IDs + new classes for preview buttons * capitalize comment in wiki Post comment form * change references to new preview button classes & IDs * change preview ID to match comment editor's * change CSS for new comment preview IDs * change preview button CSS selector
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* rename method for making comment element IDs * add unique IDs + new classes for preview buttons * capitalize comment in wiki Post comment form * change references to new preview button classes & IDs * change preview ID to match comment editor's * change CSS for new comment preview IDs * change preview button CSS selector
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* rename method for making comment element IDs * add unique IDs + new classes for preview buttons * capitalize comment in wiki Post comment form * change references to new preview button classes & IDs * change preview ID to match comment editor's * change CSS for new comment preview IDs * change preview button CSS selector
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* rename method for making comment element IDs * add unique IDs + new classes for preview buttons * capitalize comment in wiki Post comment form * change references to new preview button classes & IDs * change preview ID to match comment editor's * change CSS for new comment preview IDs * change preview button CSS selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will leave more detailed inline comments in the reviews for each file.
(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)