Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question input title -- fixes #708 #889

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Conversation

ryzokuken
Copy link
Member

@ryzokuken ryzokuken commented Oct 14, 2016

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • All tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer
  • schema.rb.example has been updated if any database migrations were added

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

Fixed issue #708
#708

Finally tested the code on this branch.

@jywarren please review.

@ryzokuken ryzokuken changed the title fix #708 fix issue #708 Oct 14, 2016
@jywarren jywarren changed the title fix issue #708 Question input title -- fixes #708 Oct 14, 2016
@jywarren
Copy link
Member

This is perfect, thanks!

We're starting to get low on first-timers-only issues! That's great! I'll try to circle back and add a few more.

@jywarren jywarren merged commit 545419c into publiclab:master Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants