-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[System Tests] Post Replies with Multiple Comment Boxes Open #8881
Conversation
Code Climate has analyzed commit e5a26d1 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #8881 +/- ##
=======================================
Coverage ? 81.85%
=======================================
Files ? 100
Lines ? 5935
Branches ? 0
=======================================
Hits ? 4858
Misses ? 1077
Partials ? 0 |
Another way to do it is to add the comments within the test, using |
Thank you @jywarren, I didn't know about I'll make some time toward the end of the internship to clean up all the tests and fixtures I'm making, will probably use that if these fixtures don't get much use. |
Oh yeah this is ready to merge too! |
Yay!!! |
* add new wiki/note/question fixtures w/ multiple comments * +1 assertions that count questions/wikis/notes * new test: post replies w/ multiple comment boxes * remove take_screenshot
* add new wiki/note/question fixtures w/ multiple comments * +1 assertions that count questions/wikis/notes * new test: post replies w/ multiple comment boxes * remove take_screenshot
* add new wiki/note/question fixtures w/ multiple comments * +1 assertions that count questions/wikis/notes * new test: post replies w/ multiple comment boxes * remove take_screenshot
* add new wiki/note/question fixtures w/ multiple comments * +1 assertions that count questions/wikis/notes * new test: post replies w/ multiple comment boxes * remove take_screenshot
I have another PR open at #8879, merge that one first!
(This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)