[System Tests] Comment On Question, Then Immediately Respond

[noi5e]

Added new test for Question pages:

• post comment to a Question page
• respond to the freshly posted comment
  • I understand the comment box is freshly made by JS...
  • so this is testing an asynchronous comment action

Small concerns:

• I ran all the tests locally, so this shouldn't be introducing any new failures/errors
• there may be merge conflicts bc the commits include fixtures that have already been merged into main
• please review the new test below, it's a little more complex than usual.
  • in particular I used XPath to find a parent element. I know XPath is a bit slower than CSS, but don't know if there's a CSS workaround.

  test 'question page: reply to freshly posted comment' do
    visit nodes(:question4).path
    # post new comment
    comment_text = 'woot woot'
    page.evaluate_script("addComment('#{comment_text}', '/comment/create/#{nodes(:question4).nid}')")
    # we need the ID of parent div that contains <p>comment_text</p>:
    parent_id = page.find('p', text: comment_text).find(:xpath, '..')[:id]
    # regex to strip the ID number out of string. ID format is comment-body-4231
    parent_id_num = /comment-body-(\d+)/.match(parent_id)[1]
    # reply to comment
    comment_response_text = 'wooly woot!'
    # addComment(comment text, submitURL, comment's parent ID)
    page.evaluate_script("addComment('#{comment_response_text}', '/comment/create/#{nodes(:question4).nid}', #{parent_id_num})")
    # assert that <div id="c1show"> has child div[div[p[text="wooly woot!"]]]
    assert_selector("#{'#c' + parent_id_num + 'show'} div div div p", text: comment_response_text)
  end

(This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)

[gitpod-io]

[codeclimate]

Code Climate has analyzed commit f406c0d and detected 0 issues on this pull request.

View more on Code Climate.

[jywarren]

This looks great. It passes locally? Awesome work!

[noi5e]

Ah yeah, I didn't make that clear: yep the tests look good locally!

[jywarren]

Fantastic!!