Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "# more" which expands to show tags #8571 #8581

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Fixed "# more" which expands to show tags #8571 #8581

merged 3 commits into from
Oct 16, 2020

Conversation

nk183
Copy link
Contributor

@nk183 nk183 commented Oct 15, 2020

Fixes #8571

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 15, 2020

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #8581 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8581   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         101      101           
  Lines        5901     5901           
=======================================
  Hits         4825     4825           
  Misses       1076     1076           

Copy link
Contributor

@Cadreia Cadreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nk183 Thanks for opening this pull request! Could you please add the issue link to the issue this pull request fixes on the line "Fixes #0000", replacing #0000 with the issue number (#8571)? This will help other contributors review your changes. It also helps in automatically closing the issue when the pull request is merged.
Other than that, you did a great job!

@nk183
Copy link
Contributor Author

nk183 commented Oct 15, 2020

I have add the issue link
thank you Ma'am @Cadreia

@nk183
Copy link
Contributor Author

nk183 commented Oct 16, 2020

@Cadreia please merge my pull request

Copy link
Contributor

@Cadreia Cadreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems okay now

@Cadreia
Copy link
Contributor

Cadreia commented Oct 16, 2020

@jywarren and @cesswairimu, can you please review this pull request

@jywarren
Copy link
Member

Really well done, @nk183 and thank you @Cadreia for supporting here!!!

@jywarren jywarren merged commit 0d0f92d into publiclab:main Oct 16, 2020
@welcome
Copy link

welcome bot commented Oct 16, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
)

* added a circle+ which expands to show all tags

* Fixed # more link so that it expands to show more tags publiclab#8571

* Fixed # more link so that it expands to show more tags publiclab#8571
@cesswairimu cesswairimu mentioned this pull request Oct 22, 2020
5 tasks
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
)

* added a circle+ which expands to show all tags

* Fixed # more link so that it expands to show more tags publiclab#8571

* Fixed # more link so that it expands to show more tags publiclab#8571
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
)

* added a circle+ which expands to show all tags

* Fixed # more link so that it expands to show more tags publiclab#8571

* Fixed # more link so that it expands to show more tags publiclab#8571
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
)

* added a circle+ which expands to show all tags

* Fixed # more link so that it expands to show more tags publiclab#8571

* Fixed # more link so that it expands to show more tags publiclab#8571
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
)

* added a circle+ which expands to show all tags

* Fixed # more link so that it expands to show more tags publiclab#8571

* Fixed # more link so that it expands to show more tags publiclab#8571
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
)

* added a circle+ which expands to show all tags

* Fixed # more link so that it expands to show more tags publiclab#8571

* Fixed # more link so that it expands to show more tags publiclab#8571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "# more" link so that it expands to show more tags
3 participants