-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed "# more" which expands to show tags #8571 #8581
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8581 +/- ##
=======================================
Coverage 81.76% 81.76%
=======================================
Files 101 101
Lines 5901 5901
=======================================
Hits 4825 4825
Misses 1076 1076 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nk183 Thanks for opening this pull request! Could you please add the issue link to the issue this pull request fixes on the line "Fixes #0000", replacing #0000 with the issue number (#8571)? This will help other contributors review your changes. It also helps in automatically closing the issue when the pull request is merged.
Other than that, you did a great job!
I have add the issue link |
@Cadreia please merge my pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems okay now
@jywarren and @cesswairimu, can you please review this pull request |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
) * added a circle+ which expands to show all tags * Fixed # more link so that it expands to show more tags publiclab#8571 * Fixed # more link so that it expands to show more tags publiclab#8571
) * added a circle+ which expands to show all tags * Fixed # more link so that it expands to show more tags publiclab#8571 * Fixed # more link so that it expands to show more tags publiclab#8571
) * added a circle+ which expands to show all tags * Fixed # more link so that it expands to show more tags publiclab#8571 * Fixed # more link so that it expands to show more tags publiclab#8571
) * added a circle+ which expands to show all tags * Fixed # more link so that it expands to show more tags publiclab#8571 * Fixed # more link so that it expands to show more tags publiclab#8571
) * added a circle+ which expands to show all tags * Fixed # more link so that it expands to show more tags publiclab#8571 * Fixed # more link so that it expands to show more tags publiclab#8571
) * added a circle+ which expands to show all tags * Fixed # more link so that it expands to show more tags publiclab#8571 * Fixed # more link so that it expands to show more tags publiclab#8571
Fixes #8571
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!