Fix rubocop config to remove error messages

[oedbro]

One step in fixing #6340

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Hopefully I did things correct with this PR, if not please let me know so I can learn.

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

[gitpod-io]

[codeclimate]

Code Climate has analyzed commit 31cb581 and detected 37 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Style	37

View more on Code Climate.

[codecov]

Codecov Report

Merging #8526 into main will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8526      +/-   ##
==========================================
- Coverage   82.01%   81.79%   -0.22%     
==========================================
  Files         101      101              
  Lines        5899     5894       -5     
==========================================
- Hits         4838     4821      -17     
- Misses       1061     1073      +12     

Impacted Files	Coverage Δ
app/models/node.rb	91.45% <ø> (-0.07%)	⬇️
app/controllers/comment_controller.rb	86.95% <100.00%> (ø)
app/controllers/map_controller.rb	50.00% <100.00%> (ø)
app/controllers/questions_controller.rb	90.78% <100.00%> (ø)
app/controllers/search_controller.rb	97.67% <100.00%> (ø)
app/controllers/users_controller.rb	81.04% <100.00%> (-0.08%)	⬇️
app/models/answer.rb	73.68% <0.00%> (-26.32%)	⬇️
app/models/answer_selection.rb	31.25% <0.00%> (-6.25%)	⬇️
app/services/execute_search.rb	88.88% <0.00%> (-5.56%)	⬇️
app/api/srch/search.rb	66.87% <0.00%> (-3.83%)	⬇️
... and 1 more

[jywarren]

Hi, i'm so sorry to have missed this. I really appreciate it. I'm not completely sure what each change does, and I don't want to have to ask you to explain every line, but could you offer us an overview of what changes you made and how you approached them? Thank you!

[oedbro]

Hi,

No worries, the changes was performed by stepping through the output of the linter, and changing the lines to follow the styleguide. As you say this was a long time ago and I sadly do not remember the exact logic behind each of the changes more than I documented in the individual commits. I might get back to this one day, but for the time being I do not have the time so I recommend closing the pull-request for now and giving somebody else the possibility to take a look at the issue.

[jywarren]

Thank you for your contribution! I'll do that, and apologies again!