Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam2 minor bug fixes #8352

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Spam2 minor bug fixes #8352

merged 2 commits into from
Aug 25, 2020

Conversation

keshavsethi
Copy link
Member

@jywarren I found few errors in spam2 (stable). I fixed them here. Please review!!
Thanks!!

@gitpod-io
Copy link

gitpod-io bot commented Aug 25, 2020

@keshavsethi keshavsethi requested a review from jywarren August 25, 2020 19:55
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #8352 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8352   +/-   ##
=======================================
  Coverage   81.86%   81.86%           
=======================================
  Files         101      101           
  Lines        5900     5900           
=======================================
  Hits         4830     4830           
  Misses       1070     1070           
Impacted Files Coverage Δ
app/controllers/spam2_controller.rb 71.84% <100.00%> (ø)

@jywarren jywarren merged commit 9b83563 into publiclab:main Aug 25, 2020
@jywarren
Copy link
Member

Nice!!!

nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
* minor bugs fixes

* spam2 minor errors
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* minor bugs fixes

* spam2 minor errors
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* minor bugs fixes

* spam2 minor errors
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* minor bugs fixes

* spam2 minor errors
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* minor bugs fixes

* spam2 minor errors
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* minor bugs fixes

* spam2 minor errors
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* minor bugs fixes

* spam2 minor errors
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* minor bugs fixes

* spam2 minor errors
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* minor bugs fixes

* spam2 minor errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants