Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for wiki tag input field #8295

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Add test for wiki tag input field #8295

merged 5 commits into from
Aug 14, 2020

Conversation

Shulammite-Aso
Copy link
Collaborator

Fixes #8294

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Aug 14, 2020

@codecov
Copy link

codecov bot commented Aug 14, 2020 •
edited
Loading

Codecov Report

Merging #8295 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8295   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         101      101           
  Lines        5859     5859           
=======================================
  Hits         4762     4762           
  Misses       1097     1097

@Shulammite-Aso
Copy link
Collaborator Author

Hi @jywarren @sagarpreet-chadha , please review.

Thanks!

jywarren
jywarren approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Nice and simple 🎉

@jywarren jywarren merged commit dcdb868 into publiclab:main Aug 14, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
@Shulammite-Aso @nadimakhtar97
Add test for wiki tag input field (publiclab#8295)
ac668ef 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
@Shulammite-Aso @shubhangikori
Add test for wiki tag input field (publiclab#8295)
ccb25f5 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
@Shulammite-Aso @alvesitalo
Add test for wiki tag input field (publiclab#8295)
9074cdd 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
@Shulammite-Aso
Add test for wiki tag input field (publiclab#8295)
0a9c740 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
@Shulammite-Aso @manchere
Add test for wiki tag input field (publiclab#8295)
36b202f 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
@Shulammite-Aso @lagunasmel
Add test for wiki tag input field (publiclab#8295)
55e9179 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@Shulammite-Aso @reginaalyssa
Add test for wiki tag input field (publiclab#8295)
0baffca 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
@Shulammite-Aso
Add test for wiki tag input field (publiclab#8295)
27ef81d 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@Shulammite-Aso @billymoroney1
Add test for wiki tag input field (publiclab#8295)
dfbdc8e 
* add tag input field to wiki editor

* fix code climate issue

* leave space between tag_input field an other buttons

* add test for wiki tag input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add test for new wiki tag_input field
2 participants
@Shulammite-Aso @jywarren