Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated main Image module in Rich.html.erb #8290

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

NitinBhasneria
Copy link
Collaborator

Fixes publiclab/PublicLab.Editor#591 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@NitinBhasneria NitinBhasneria requested a review from a team as a code owner August 12, 2020 08:08
@gitpod-io
Copy link

gitpod-io bot commented Aug 12, 2020

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #8290 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8290   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files         101      101           
  Lines        5859     5859           
=======================================
  Hits         4769     4769           
  Misses       1090     1090           

Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks for making PR 🎉

@jywarren jywarren merged commit e2f15fe into publiclab:main Aug 12, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Co-authored-by: NitinBhasneria <nitinbhasnerai360@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main Image upload bug in plots2 - urgent!
3 participants