Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcc on moderator spam digest email #8275

Merged
merged 1 commit into from
Aug 11, 2020
Merged

bcc on moderator spam digest email #8275

merged 1 commit into from
Aug 11, 2020

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Aug 8, 2020

Hi @keshavsethi - noted that the spam digest email showed all moderator emails, which is not that big a deal as they are all approved and managed by PL staff, but I felt it was probably better to put them in bcc, unless @ebarry feels differently!

Screen Shot 2020-08-08 at 3 36 13 PM

But, the email is definitely working! Great job!

@gitpod-io
Copy link

gitpod-io bot commented Aug 8, 2020

mail(to: moderators, subject: @subject)
mail(
to: "moderators@#{ActionMailer::Base.default_url_options[:host]}",
bcc: moderators,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebarry @jywarren Sorry for the late reply. This is really awesome. Is there any other issue with the digest?? and I will surely work on its UI in few days
Thanks @jywarren @ebarry 🎉 ❤️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. It seems to be working otherwise!

@jywarren jywarren requested a review from keshavsethi August 8, 2020 19:37
@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #8275 into main will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8275   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files         101      101           
  Lines        5873     5873           
=======================================
  Hits         4776     4776           
  Misses       1097     1097           
Impacted Files Coverage Δ
app/mailers/admin_mailer.rb 90.90% <0.00%> (ø)

@jywarren jywarren merged commit 0cb23d3 into main Aug 11, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants