-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bcc on moderator spam digest email #8275
Conversation
mail(to: moderators, subject: @subject) | ||
mail( | ||
to: "moderators@#{ActionMailer::Base.default_url_options[:host]}", | ||
bcc: moderators, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. It seems to be working otherwise!
Codecov Report
@@ Coverage Diff @@
## main #8275 +/- ##
=======================================
Coverage 81.32% 81.32%
=======================================
Files 101 101
Lines 5873 5873
=======================================
Hits 4776 4776
Misses 1097 1097
|
Hi @keshavsethi - noted that the spam digest email showed all moderator emails, which is not that big a deal as they are all approved and managed by PL staff, but I felt it was probably better to put them in bcc, unless @ebarry feels differently!
But, the email is definitely working! Great job!