Don't let newcomers edit wiki pages (controller-level)

[jywarren]

No description provided.

[gitpod-io]

[codecov]

Codecov Report

Merging #8250 into main will decrease coverage by 0.25%.
The diff coverage is 63.49%.

@@            Coverage Diff             @@
##             main    #8250      +/-   ##
==========================================
- Coverage   81.70%   81.44%   -0.26%     
==========================================
  Files         100      101       +1     
  Lines        5847     5873      +26     
==========================================
+ Hits         4777     4783       +6     
- Misses       1070     1090      +20     

Impacted Files	Coverage Δ
app/controllers/spam2_controller.rb	61.53% <7.14%> (-14.06%)	⬇️
app/controllers/batch_controller.rb	67.96% <67.96%> (ø)
app/controllers/wiki_controller.rb	85.22% <100.00%> (+0.22%)	⬆️
app/models/node_tag.rb	100.00% <100.00%> (ø)
app/models/tag.rb	97.47% <100.00%> (-0.03%)	⬇️
app/api/srch/search.rb	70.06% <0.00%> (+3.82%)	⬆️
app/services/execute_search.rb	94.44% <0.00%> (+5.55%)	⬆️

[jywarren]

Great -

 FAIL["test_disallow_viewing_edit_wiki_page_for_first-timers", #<Minitest::Reporters::Suite:0x0000000012000048 @name="WikiControllerTest">, 81.481001566]
 test_disallow_viewing_edit_wiki_page_for_first-timers#WikiControllerTest (81.48s)
        --- expected
        +++ actual
        @@ -1 +1 @@
        -nil
        +"Please post a question or other content before editing the wiki. Click <a href='https://publiclab.org/notes/tester/04-23-2016/new-moderation-system-for-first-time-posters'>here</a> to learn why."
        test/functional/wiki_controller_test.rb:150:in `block in <class:WikiControllerTest>'

[jywarren]

Hmm:

 FAIL["test_basic_user_blocked_from_editing_a_locked_wiki_page", #<Minitest::Reporters::Suite:0x000000000b7bdee0 @name="WikiControllerTest">, 43.298456568999995]
 test_basic_user_blocked_from_editing_a_locked_wiki_page#WikiControllerTest (43.30s)
        --- expected
        +++ actual
        @@ -1 +1 @@
        -nil
        +"This page is <a href='/wiki/power-tags#Locking'>locked</a>, and only <a href='/wiki/moderators'>moderators</a> can edit it."
        test/functional/wiki_controller_test.rb:173:in `block in <class:WikiControllerTest>'
 FAIL["test_viewing_edit_wiki_page", #<Minitest::Reporters::Suite:0x0000000009f8a468 @name="WikiControllerTest">, 47.288350495]
 test_viewing_edit_wiki_page#WikiControllerTest (47.29s)
        expecting <"wiki/edit"> but rendering with <[]>
        test/functional/wiki_controller_test.rb:135:in `block in <class:WikiControllerTest>'

Oh, i should use a different wiki page!

[jywarren]

Hmm. I can't seem to get past these two test failures... very strange.

[jywarren]

Trying to remove the logout/login code to see if we fail our new test instead of those other two... i can't otherwise see how we're affecting them?

    UserSession.find.destroy if UserSession.find
    UserSession.create(users(:newcomer))

[jywarren]

OK! all that's left is:

 FAIL["test_viewing_edit_wiki_page", #<Minitest::Reporters::Suite:0x000000000db38c58 @name="WikiControllerTest">, 75.507005142]
 test_viewing_edit_wiki_page#WikiControllerTest (75.51s)
        expecting <"wiki/edit"> but rendering with <[]>
        test/functional/wiki_controller_test.rb:135:in `block in <class:WikiControllerTest>'

[jywarren]

 FAIL["test_viewing_edit_wiki_page", #<Minitest::Reporters::Suite:0x000000000cfccdb0 @name="WikiControllerTest">, 11.398483155999998]
 test_viewing_edit_wiki_page#WikiControllerTest (11.40s)
        Expected true to be nil or false
        test/functional/wiki_controller_test.rb:135:in `block in <class:WikiControllerTest>'

[jywarren]

LOL ok Bob is a first-timer, thus failing the original test!

[jywarren]

Whew!!!