-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced .count and .length in user model with .size #8206 Issue reso… #8227
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Please help @publiclab/reviewers |
Codecov Report
@@ Coverage Diff @@
## main #8227 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 100 100
Lines 5846 5846
=======================================
Hits 4783 4783
Misses 1063 1063
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯
@cesswairimu @Tlazypanda can you guys also review this PR once? Thanks 🎉
Thanks @sagarpreet-chadha we are getting the same error at #8219 ...I am checking further what's wrong the failing test. |
Quick update..the tests started failing on main after the last two commits.. I am tracing back from those |
Missing surrounding space provided for operator === publiclab#8227
Can I get help in solving the failed build? Thank you so much. |
Hi @AgyeyaMishra ..sure , we would love your help |
All solved..restarting travis |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thanks @sagarpreet-chadha 💯 for the review...Thanks @AgyeyaMishra for working on this 🎉 and welcome to PublicLab 🎈 |
Thank you so much for helping as well as approving the PR. It was a great experience! |
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…ssue reso… (publiclab#8227) * Replaced .count and .length in user model with .size publiclab#8206 Issue resolved * Missing surrounding space provided for operator ===
…lved
Fixes #8206 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!