Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced .count and .length in user model with .size #8206 Issue reso… #8227

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

AgyeyaMishra
Copy link
Contributor

…lved

Fixes #8206 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Aug 1, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Aug 1, 2020

@AgyeyaMishra
Copy link
Contributor Author

Please help @publiclab/reviewers

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #8227 into main will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8227   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files         100      100           
  Lines        5846     5846           
=======================================
  Hits         4783     4783           
  Misses       1063     1063           
Impacted Files Coverage Δ
app/models/user.rb 87.68% <85.71%> (ø)

Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯
@cesswairimu @Tlazypanda can you guys also review this PR once? Thanks 🎉

@cesswairimu
Copy link
Collaborator

Thanks @sagarpreet-chadha we are getting the same error at #8219 ...I am checking further what's wrong the failing test.

@cesswairimu
Copy link
Collaborator

Quick update..the tests started failing on main after the last two commits.. I am tracing back from those

Missing surrounding space provided for operator === publiclab#8227
@AgyeyaMishra
Copy link
Contributor Author

Quick update..the tests started failing on main after the last two commits.. I am tracing back from those

Can I get help in solving the failed build? Thank you so much.

@cesswairimu
Copy link
Collaborator

Hi @AgyeyaMishra ..sure , we would love your help

@cesswairimu
Copy link
Collaborator

All solved..restarting travis

@cesswairimu cesswairimu closed this Aug 3, 2020
@cesswairimu cesswairimu reopened this Aug 3, 2020
@gitpod-io
Copy link

gitpod-io bot commented Aug 3, 2020

@cesswairimu cesswairimu merged commit f6f4a6d into publiclab:main Aug 3, 2020
@welcome
Copy link

welcome bot commented Aug 3, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@cesswairimu
Copy link
Collaborator

cesswairimu commented Aug 3, 2020

Thanks @sagarpreet-chadha 💯 for the review...Thanks @AgyeyaMishra for working on this 🎉 and welcome to PublicLab 🎈

@AgyeyaMishra
Copy link
Contributor Author

Thanks @sagarpreet-chadha for the review...Thanks @AgyeyaMishra for working on this and welcome to PublicLab

Thank you so much for helping as well as approving the PR. It was a great experience!

cypherean pushed a commit to cypherean/plots2 that referenced this pull request Aug 5, 2020
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
dms-yondy pushed a commit to dms-yondy/plots2 that referenced this pull request Aug 7, 2020
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
…ssue reso… (publiclab#8227)

* Replaced .count and .length in user model with .size publiclab#8206 Issue resolved

* Missing surrounding space provided for operator ===
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace .count and .length in user model with .size
3 participants