-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: remove n+1 query from user#tagnames method #8190
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8190 +/- ##
==========================================
- Coverage 82.10% 81.81% -0.30%
==========================================
Files 100 100
Lines 5751 5846 +95
==========================================
+ Hits 4722 4783 +61
- Misses 1029 1063 +34
|
Can you paste the SQL queries executed from the server console in both cases? Maybe that will help to figure out? |
@sagarpreet-chadha Yeah surely I will look into it 😅 Thanks for the review 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Fixes #8189
Removed n+1 query problem from user#tagnames method
rake test
@publiclab/reviewers
for help, in a comment belowThanks!