Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes parsing multiple subscription signup #8166 #8176

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Fixes parsing multiple subscription signup #8166 #8176

merged 3 commits into from
Jul 21, 2020

Conversation

jywarren
Copy link
Member

Fixes #8166

@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Jul 21, 2020 •
edited
Loading

Codecov Report

Merging #8176 into main will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8176      +/-   ##
==========================================
+ Coverage   81.69%   81.81%   +0.12%     
==========================================
  Files         100      100              
  Lines        5845     5846       +1     
==========================================
+ Hits         4775     4783       +8     
+ Misses       1070     1063       -7
Impacted Files Coverage Δ
app/controllers/subscription_controller.rb 70.70% <100.00%> (+0.29%) ⬆️
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@jywarren
Copy link
Member Author

Ohhhhhhhh


 FAIL["test_should_redirect_properly_when_subscribing_to_multiple_tags", #<Minitest::Reporters::Suite:0x000000001062e5e8 @name="SubscriptionControllerTest">, 29.610231640999984]
 test_should_redirect_properly_when_subscribing_to_multiple_tags#SubscriptionControllerTest (29.61s)
        --- expected
        +++ actual
        @@ -1 +1 @@
        -"You are now following [\"blog\", \"kites\", \"\", \"balloon\", \"awesome\"]."
        +"You are now following blog, kites, , balloon, awesome."
        test/functional/subscription_controller_test.rb:64:in `block in <class:SubscriptionControllerTest>'

jywarren
jywarren commented Jul 21, 2020
View reviewed changes
app/controllers/subscription_controller.rb Outdated
@@ -159,7 +159,7 @@ def multiple_add
if request.xhr?
render json: true
else
flash[:notice] = "You are now following #{params[:tagnames].join(', ')}."
flash[:notice] = "You are now following #{params[:tagnames]}."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.

@jywarren
Copy link
Member Author

https://github.com/publiclab/plots2/blob/fixes-multisubscription/test/functional/subscription_controller_test.rb#L64

@jywarren
Copy link
Member Author

Nope... 😭

ERROR["test_should_redirect_properly_when_subscribing_to_multiple_tags", #<Minitest::Reporters::Suite:0x0000000011550030 @name="SubscriptionControllerTest">, 52.44063293400001]
 test_should_redirect_properly_when_subscribing_to_multiple_tags#SubscriptionControllerTest (52.44s)
Minitest::UnexpectedError:         NoMethodError: undefined method `join' for nil:NilClass
            app/controllers/subscription_controller.rb:162:in `block (2 levels) in multiple_add'
            app/controllers/subscription_controller.rb:157:in `multiple_add'
            test/functional/subscription_controller_test.rb:62:in `block in <class:SubscriptionControllerTest>'
ERROR["test_should_subscribe_to_multiple_tags", #<Minitest::Reporters::Suite:0x00000000118bec30 @name="SubscriptionControllerTest">, 52.558379075000005]
 test_should_subscribe_to_multiple_tags#SubscriptionControllerTest (52.56s)
Minitest::UnexpectedError:         NoMethodError: undefined method `join' for nil:NilClass
            app/controllers/subscription_controller.rb:162:in `block (2 levels) in multiple_add'
            app/controllers/subscription_controller.rb:157:in `multiple_add'
            test/functional/subscription_controller_test.rb:31:in `block in <class:SubscriptionControllerTest>'

@jywarren jywarren merged commit 0a4b058 into main Jul 21, 2020
@jywarren
Copy link
Member Author

Hooray!!

dms-yondy pushed a commit to dms-yondy/plots2 that referenced this pull request Aug 7, 2020
@jywarren
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
91a233a 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
@jywarren @nadimakhtar97
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
a95d54a 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
@jywarren @shubhangikori
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
517bc9a 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
@jywarren @alvesitalo
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
dfc2037 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
@jywarren
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
d907796 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
@jywarren @manchere
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
9add6f1 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
@jywarren @lagunasmel
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
359aca8 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@jywarren @reginaalyssa
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
e73b1e7 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
@jywarren
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
974cf16 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@jywarren @billymoroney1
Fixes parsing multiple subscription signup publiclab#8166 (publiclab#…
8efcd51 
…8176)

* Fixes parsing multiple subscription signup publiclab#8166

* Update subscription_controller.rb

* Update subscription_controller.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on parsing multiple subscription signup
1 participant
@jywarren