Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam2: Unmoderated Digest UI update #8130

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Conversation

keshavsethi
Copy link
Member

I have updated UI of spam2 unmoderated nodes digest. I have also added image of nodes in the digest. Please refer to following Screenshots
ezgif com-crop (4)
Screenshot_2020-07-10 Your daily digest for moderation
Screenshot from 2020-07-10 07-52-17
Screenshot from 2020-07-10 07-48-26
@jywarren @pydevsg @emilyashley @ebarry @ananyaarun @cesswairimu Please review
Thanks!

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow these are looking great..love the images on the mail 🎉 🎉 ...The mobile view one looks perfect...is there a way we can make the image on the PC view look nicer..it looks stretched out...or maybe it will look better in production?

@keshavsethi
Copy link
Member Author

Wow these are looking great..love the images on the mail ...The mobile view one looks perfect...is there a way we can make the image on the PC view look nicer..it looks stretched out...or maybe it will look better in production?

Sure, I will do that Thanks!!

@keshavsethi keshavsethi requested a review from cesswairimu July 14, 2020 12:42
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@f34e477). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8130   +/-   ##
=======================================
  Coverage        ?   82.10%           
=======================================
  Files           ?      100           
  Lines           ?     5768           
  Branches        ?        0           
=======================================
  Hits            ?     4736           
  Misses          ?     1032           
  Partials        ?        0           
Impacted Files Coverage Δ
app/models/user.rb 87.73% <0.00%> (ø)

@keshavsethi
Copy link
Member Author

Wow these are looking great..love the images on the mail ...The mobile view one looks perfect...is there a way we can make the image on the PC view look nicer..it looks stretched out...or maybe it will look better in production?

@cesswairimu I think it is fine now
Screenshot from 2020-07-14 17-48-24

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🎉 these look great

@cesswairimu cesswairimu merged commit d0370d5 into publiclab:main Jul 16, 2020
Tristan-Elizabeth pushed a commit to Tristan-Elizabeth/plots2 that referenced this pull request Jul 21, 2020
* spam2 UI update

* remove tag filter
dms-yondy pushed a commit to dms-yondy/plots2 that referenced this pull request Aug 7, 2020
* spam2 UI update

* remove tag filter
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
* spam2 UI update

* remove tag filter
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* spam2 UI update

* remove tag filter
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* spam2 UI update

* remove tag filter
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* spam2 UI update

* remove tag filter
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* spam2 UI update

* remove tag filter
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* spam2 UI update

* remove tag filter
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* spam2 UI update

* remove tag filter
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* spam2 UI update

* remove tag filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants