add environments to skylight

[Tlazypanda]

Fixes #8103

Added stable and unstable environments to skylight.

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Thanks!

[codecov]

Codecov Report

Merging #8104 into main will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8104      +/-   ##
==========================================
- Coverage   82.05%   82.05%   -0.01%     
==========================================
  Files         100      100              
  Lines        5773     5772       -1     
==========================================
- Hits         4737     4736       -1     
  Misses       1036     1036              

Impacted Files	Coverage Δ
app/controllers/application_controller.rb	92.30% <ø> (ø)
app/controllers/tag_controller.rb	81.34% <100.00%> (-0.06%)	⬇️

[Tlazypanda]

Hey @jywarren @cesswairimu can you kindly review? Thanks ✌️ I copied the production settings for stable and unstable and changed the hosts in the files and added it to the skylight environment 😅

[Tlazypanda]

Hey @jywarren I think the tests are passing when you check it on the travis pr page but its status on github is not changing 😅

[jywarren]

Hmmmmmm something is fishy here.

[jywarren]

These at least don't seem to be completed: https://github.com/publiclab/plots2/pull/8104/checks?check_run_id=825545745

[jywarren]

The ones that aren't passing here are from 6 days ago. Would you mind trying to rebase this to see if we get a clean run? I wonder if it's related to the switch to Travis-ci.com from Travis-ci.org?

https://github.com/publiclab/plots2/pull/8104/checks?check_run_id=825545745

Thank you and sorry for the trouble!

[Tlazypanda]

Hey @jywarren actually I opened the jobs on the link that you sent which show as yellow now but on opening them it is green 😅 is this from before test? Ohh yes just checked those are the ones triggered before my bad sorry 😅 I will take a rebase

[Tlazypanda]

Hey @jywarren just adding to the slow travis test point that you mentioned, the tests in this run are still queued and haven't even started yet https://travis-ci.com/github/publiclab/plots2/jobs/358427078 😅

[jywarren]

Hmm. I wonder if we're hitting a rate limit. I have restarted a TON of travis tests today.

[jywarren]

This looks great! Thank you!!! cc @icarito bc we would have split config files. Just checking that's OK?

[icarito]

Hi!
Sorry for the delay in reviewing.
I see a lot of duplication here, could this rather be accomplished by environment variables rather than having one config per environment?
The idea currently is that staging runs in production mode so that it is as close as possible to actual production.
We currently have one config for each environment in containers/ but I would also like to refactor those into one with env variables.

[icarito]

I'm unfamiliar with rails environments and skylight environments, currently we run staging in production mode. Would these changes affect this?
If not I'm fine with adding extra config for Skylight, if env variables would help to avoid duplication that'd be awesome.

[jywarren]

Hi @Tlazypanda do you have any insight on this q from @icarito? Thank you!

[jywarren]

Do these extend the existing configs, or replace them? Thanks!

[Tlazypanda]

Hey @jywarren since this is a new area for me I am not completely sure how to implement on ENV variables 😅 I also did some digging but couldn't find much around it catered to rails environments 😅 As for the extending/replacing thing I think it's replacing on it since that is how it is in the other development/test environments as well and I have copied the entire production config here and just changed the hosts 😅 any guidance/help on this will be appreciated I did see that we can import files to reduce redundancy but that was not in the case of environments so I am not sure if that will work here

[jywarren]

Hi, well, if you are pretty sure this will only affect the skylight run and environment, I think this is OK! Let's merge it - if we find something goes wrong, we can revert back, it's not such a big thing. Thanks and I appreciate your patience as we're pretty careful with this!

[jywarren]

🎉

[jywarren]

Just noting docs for this here:

https://www.skylight.io/support/environments

If it doesn't work, we could revert and try the env variable approach listed there!

https://www.skylight.io/support/environments#for-rails-using-environment-variables

@Tlazypanda i invited you to our Skylight account! I don't see the new env yet, but, hopefully soon!

[Tlazypanda]

Hey @jywarren I am not sure why the environment is not showing 😅 can we try the second approach? I am not sure where we are supposed to add the environment variables for that (is it the docker compose files for stable and unstable?)

But I am not sure why this is not working though 😥 @icarito can you please weigh in ..I am kinda new to this environment and env thing and feel might be making some silly mistakes

[icarito]

I think https://www.skylight.io/support/environments#3-optional-specify-an-environment-name seems to indicate that the SKYLIGHT_ENV needs to be set if we don't change RAILS_ENV (and we don't, staging mimics production so it has same RAILS_ENV).
So I've set SKYLIGHT_ENV for unstable branch in staging, and also made relevant changes to docker-compose-unstable.yml file. If it works we can extend the solution and set more environment variables.

[jywarren]

@Tlazypanda did that end up working out?

[Tlazypanda]

Hey @jywarren I think what @icarito has done works 🎉 since I can see unstable as an option in the skylight dropdown 💯
Thanks @icarito!!