Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bundler before bundle install #8101

Merged
merged 14 commits into from
Jul 1, 2020
Merged

Update bundler before bundle install #8101

merged 14 commits into from
Jul 1, 2020

Conversation

icarito
Copy link
Member

@icarito icarito commented Jun 30, 2020

Another attempt this time at upgrading bundler to bundler2.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited
Loading

Codecov Report

Merging #8101 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8101   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         100      100           
  Lines        5773     5773           
=======================================
  Hits         4737     4737           
  Misses       1036     1036

@icarito icarito mentioned this pull request Jun 30, 2020
Closed
@icarito
Copy link
Member Author

icarito commented Jul 1, 2020

Okay one of the issues that I think may want some discussion is that we were doing bundle update during Docker build phase, but not in Travis. Is running bundle update at deployment time desired, or rather the point of Gemfile.lock is to warrant a specific locked version known to work?

@icarito
Copy link
Member Author

icarito commented Jul 1, 2020

Eliminating the bundle update step in Dockerfile and adding bundle exec prefix allowed Jenkins and Travis to agree to build and test correctly. 🎉

@cesswairimu cesswairimu merged commit badf58e into main Jul 1, 2020
@cesswairimu
Copy link
Collaborator

Awesome thanks @icarito 🚀

@Tlazypanda
Copy link
Collaborator

Thanks @icarito 🎉 💯 !!

@jywarren
Copy link
Member

jywarren commented Jul 1, 2020

Thank you so much!!! This is awesome.

Tristan-Elizabeth pushed a commit to Tristan-Elizabeth/plots2 that referenced this pull request Jul 21, 2020
@icarito @Tristan-Elizabeth
Update bundler before bundle install (publiclab#8101)
6648e85 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
dms-yondy pushed a commit to dms-yondy/plots2 that referenced this pull request Aug 7, 2020
@icarito
Update bundler before bundle install (publiclab#8101)
b222106 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
@icarito @nadimakhtar97
Update bundler before bundle install (publiclab#8101)
43f8213 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
@icarito @shubhangikori
Update bundler before bundle install (publiclab#8101)
094dd6a 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
@icarito @alvesitalo
Update bundler before bundle install (publiclab#8101)
3b804ba 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
@icarito
Update bundler before bundle install (publiclab#8101)
00cf115 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
@icarito @manchere
Update bundler before bundle install (publiclab#8101)
e5d708b 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
@icarito @lagunasmel
Update bundler before bundle install (publiclab#8101)
0e1a813 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
@icarito
Update bundler before bundle install (publiclab#8101)
1115460 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@icarito @billymoroney1
Update bundler before bundle install (publiclab#8101)
779e9cd 
* Update bundler before bundle install

* Set new bundler as default

* Update Rubygems

From:
https://stackoverflow.com/questions/53231667/bundler-you-must-use-bundler-2-or-greater-with-this-lockfile

* Add env variable pointing to right bundler

* Try different order for bundle installation

* Update Gems before and after bundle install

* Add newer rake gem in container

* Tweak rake version

* Fix Gemfile with a generated version

* Try to call update gems only once

* Revert Gemfile.lock to manually tweaked

* Revert Gemfile.lock

* Another try to update rake

* Add bundle exec prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesswairimu cesswairimu cesswairimu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@icarito @cesswairimu @Tlazypanda @jywarren