Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-label for empty link . #8095

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conversation

nsachin08
Copy link
Member

Fixes #8094
@Tlazypanda

Thanks!

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #8095 into main will decrease coverage by 0.35%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8095      +/-   ##
==========================================
- Coverage   82.41%   82.05%   -0.36%     
==========================================
  Files          99      100       +1     
  Lines        5737     5773      +36     
==========================================
+ Hits         4728     4737       +9     
- Misses       1009     1036      +27     
Impacted Files Coverage Δ
app/controllers/application_controller.rb 92.30% <ø> (ø)
app/controllers/users_controller.rb 82.29% <ø> (ø)
app/mailers/admin_mailer.rb 90.90% <12.50%> (-9.10%) ⬇️
app/models/user.rb 86.44% <12.50%> (-4.61%) ⬇️
app/jobs/digest_spam_job.rb 33.33% <33.33%> (ø)
app/controllers/admin_controller.rb 80.00% <100.00%> (+0.25%) ⬆️

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsachin08 Looks good to me 🎉 Thanks for contributing to Public Lab 🎈

@jywarren jywarren changed the base branch from master to main June 30, 2020 19:50
@jywarren jywarren closed this Jun 30, 2020
@jywarren jywarren reopened this Jun 30, 2020
@jywarren
Copy link
Member

Hmm. Trying to retrigger this! Let's see! Thank you!!

@jywarren jywarren merged commit 396fa37 into publiclab:main Jun 30, 2020
@welcome
Copy link

welcome bot commented Jun 30, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Awesome. Thank you, and great work!!!

Tristan-Elizabeth pushed a commit to Tristan-Elizabeth/plots2 that referenced this pull request Jul 21, 2020
dms-yondy pushed a commit to dms-yondy/plots2 that referenced this pull request Aug 7, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aria-labels for empty link in dashboard/_node_question.html.erb
3 participants